You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Ian Clelland <ic...@google.com> on 2014/07/02 16:05:32 UTC
Re: Releasing contacts
Sergey, I've merged this in -- can you give it a quick test?
On Mon, Jun 30, 2014 at 7:56 AM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:
> Here is fix for CB-7003. Tested on Android 4.3 and 2.3.6
> https://github.com/apache/cordova-plugin-contacts/pull/32
>
> Thx!
> Sergey
> -----Original Message-----
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
> Sent: Friday, June 27, 2014 11:01 PM
> To: dev@cordova.apache.org
> Subject: Re: Releasing contacts
>
> That seems legitimate; I think we can delay for that.
>
> How long do you think it'll take to deal with it?
>
>
> On Fri, Jun 27, 2014 at 2:44 PM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > Hi Ian,
> >
> > I planned to take a look on CB-7003 navigator.contacts.pickContact
> > picks wrong contact on Android 4.3 and 4.4.3 versions" on Monday. It
> > will be great if we can include this fix to release.
> >
> > https://issues.apache.org/jira/browse/CB-7003
> >
> > Thx!
> > Sergey
> > -----Original Message-----
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > Ian Clelland
> > Sent: Friday, June 27, 2014 10:36 PM
> > To: dev@cordova.apache.org
> > Subject: Releasing contacts
> >
> > I've reverted the change to Contacts that switched the order of
> > parameters in navigator.contacts.find (Sorry, guys, it's just a change
> > that we can't make in a point release, no matter how out-of-line the
> > signature is with the rest of the Cordova methods)
> >
> > That fixes all of the contacts failures for me on iOS and Android, so
> > I'm going to add that to the 0.2.11 candidate release and send that
> > out for vote again. People have been asking for an update to Contacts
> > in the registry, so hopefully we can all pull together and get this
> > out there :)
> >
> > I'll start a vote thread as soon as I've created all of the necessary
> > artifacts.
> >
> > Ian
> >
>
Re: Releasing contacts
Posted by Ian Clelland <ic...@google.com>.
Cool, thanks!
I've started the vote thread for it, so we can finally get a new version of
this out. (It's been two months now since the last one)
On Wed, Jul 2, 2014 at 11:24 AM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:
> Tested merged version from apache/master on Android 4.3, works correct.
>
> -----Original Message-----
> From: Ian Clelland [mailto:iclelland@google.com]
> Sent: Wednesday, July 2, 2014 6:06 PM
> To: dev@cordova.apache.org
> Subject: Re: Releasing contacts
>
> Sergey, I've merged this in -- can you give it a quick test?
>
>
> On Mon, Jun 30, 2014 at 7:56 AM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > Here is fix for CB-7003. Tested on Android 4.3 and 2.3.6
> > https://github.com/apache/cordova-plugin-contacts/pull/32
> >
> > Thx!
> > Sergey
> > -----Original Message-----
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > Ian Clelland
> > Sent: Friday, June 27, 2014 11:01 PM
> > To: dev@cordova.apache.org
> > Subject: Re: Releasing contacts
> >
> > That seems legitimate; I think we can delay for that.
> >
> > How long do you think it'll take to deal with it?
> >
> >
> > On Fri, Jun 27, 2014 at 2:44 PM, Sergey Grebnov (Akvelon) <
> > v-segreb@microsoft.com> wrote:
> >
> > > Hi Ian,
> > >
> > > I planned to take a look on CB-7003 navigator.contacts.pickContact
> > > picks wrong contact on Android 4.3 and 4.4.3 versions" on Monday. It
> > > will be great if we can include this fix to release.
> > >
> > > https://issues.apache.org/jira/browse/CB-7003
> > >
> > > Thx!
> > > Sergey
> > > -----Original Message-----
> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> > > Of Ian Clelland
> > > Sent: Friday, June 27, 2014 10:36 PM
> > > To: dev@cordova.apache.org
> > > Subject: Releasing contacts
> > >
> > > I've reverted the change to Contacts that switched the order of
> > > parameters in navigator.contacts.find (Sorry, guys, it's just a
> > > change that we can't make in a point release, no matter how
> > > out-of-line the signature is with the rest of the Cordova methods)
> > >
> > > That fixes all of the contacts failures for me on iOS and Android,
> > > so I'm going to add that to the 0.2.11 candidate release and send
> > > that out for vote again. People have been asking for an update to
> > > Contacts in the registry, so hopefully we can all pull together and
> > > get this out there :)
> > >
> > > I'll start a vote thread as soon as I've created all of the
> > > necessary artifacts.
> > >
> > > Ian
> > >
> >
>
RE: Releasing contacts
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
Tested merged version from apache/master on Android 4.3, works correct.
-----Original Message-----
From: Ian Clelland [mailto:iclelland@google.com]
Sent: Wednesday, July 2, 2014 6:06 PM
To: dev@cordova.apache.org
Subject: Re: Releasing contacts
Sergey, I've merged this in -- can you give it a quick test?
On Mon, Jun 30, 2014 at 7:56 AM, Sergey Grebnov (Akvelon) < v-segreb@microsoft.com> wrote:
> Here is fix for CB-7003. Tested on Android 4.3 and 2.3.6
> https://github.com/apache/cordova-plugin-contacts/pull/32
>
> Thx!
> Sergey
> -----Original Message-----
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> Ian Clelland
> Sent: Friday, June 27, 2014 11:01 PM
> To: dev@cordova.apache.org
> Subject: Re: Releasing contacts
>
> That seems legitimate; I think we can delay for that.
>
> How long do you think it'll take to deal with it?
>
>
> On Fri, Jun 27, 2014 at 2:44 PM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > Hi Ian,
> >
> > I planned to take a look on CB-7003 navigator.contacts.pickContact
> > picks wrong contact on Android 4.3 and 4.4.3 versions" on Monday. It
> > will be great if we can include this fix to release.
> >
> > https://issues.apache.org/jira/browse/CB-7003
> >
> > Thx!
> > Sergey
> > -----Original Message-----
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> > Of Ian Clelland
> > Sent: Friday, June 27, 2014 10:36 PM
> > To: dev@cordova.apache.org
> > Subject: Releasing contacts
> >
> > I've reverted the change to Contacts that switched the order of
> > parameters in navigator.contacts.find (Sorry, guys, it's just a
> > change that we can't make in a point release, no matter how
> > out-of-line the signature is with the rest of the Cordova methods)
> >
> > That fixes all of the contacts failures for me on iOS and Android,
> > so I'm going to add that to the 0.2.11 candidate release and send
> > that out for vote again. People have been asking for an update to
> > Contacts in the registry, so hopefully we can all pull together and
> > get this out there :)
> >
> > I'll start a vote thread as soon as I've created all of the
> > necessary artifacts.
> >
> > Ian
> >
>