You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/17 13:23:19 UTC
[GitHub] [camel] orpiske opened a new pull request #4242: Moves the Kafka test infrastructure
orpiske opened a new pull request #4242:
URL: https://github.com/apache/camel/pull/4242
Moves part of the Kafka test infrastructure from the Camel Kafka Connector to Camel Core
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-694230502
@lburgazzoli this is related to the discussion about moving some of the reusable test infra from CKC to Camel Core.
Do you think this would do the trick for Camel Quarkus as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-695167350
> When you want @orpiske this can be merged.
Thanks Andrea, I think we are good to go.
Just let me have a quick chat w/ Luca on Monday morning to make sure this covers the basics for Camel Quarkus as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-695022589
When you want @orpiske this can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-694715389
The license headers in the XML files are using the wrong style (eg ~)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-695959980
Just talked to Luca, we are good to go. Subsequently, I can/will adjust if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #4242:
URL: https://github.com/apache/camel/pull/4242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske edited a comment on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-694230502
@lburgazzoli this is related to the discussion about moving some of the reusable test infra from CKC to Camel Core.
Do you think this would do the trick for Camel Quarkus as well?
To use the code, you can add a dependency on camel-test-infra-kafka, like this:
```
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-test-infra-kafka</artifactId>
<version>${camel.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
```
Then, the initialization of the Kafka Service is done using regular JUnit 5 extensions:
```
@RegisterExtension
public final KafkaService kafkaService = KafkaServiceFactory.createService();
```
And then use `kafkaService.getBootstrapServers()` to get the list of bootstrap servers so you can create the client and so on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske edited a comment on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-695959980
Just talked to Luca, we are good to go. Subsequently, I can/will adjust if needed.
Thanks everyone for the reviews and comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske edited a comment on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-695959980
Just talked to Luca, we are good to go. Subsequently, I can/will adjust if needed.
Thanks everyone for the reviews and comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4242:
URL: https://github.com/apache/camel/pull/4242#issuecomment-695959980
Just talked to Luca, we are good to go. Subsequently, I can/will adjust if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #4242: Moves the Kafka test infrastructure
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #4242:
URL: https://github.com/apache/camel/pull/4242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org