You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2023/08/11 00:51:59 UTC
[GitHub] [airflow] ferruzzi opened a new pull request, #33301: D205 Support - Stragglers
ferruzzi opened a new pull request, #33301:
URL: https://github.com/apache/airflow/pull/33301
Part of https://github.com/apache/airflow/issues/10742
D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be a blank line before the rest of the docstring. Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
There are almost a thousand violations in the repo so we're going to have to take this in bites.
### PLEASE NOTE
There should be zero logic changes in this PR, only changes to docstrings and whitespace. If you see otherwise, please call it out.
### Included in this chunk
A handful of files which weren't in clusters big enough to warrant their own PRs.
### To test
If you comment out [this line](https://github.com/apache/airflow/blob/main/pyproject.toml#L68) and run pre-commit in main you will get 92 errors. After these changes, only 76 remain and no files in the list above should be on the list. After uncommenting that line and rerunning pre-commits, there should be zero regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #33301: D205 Support - Stragglers
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #33301:
URL: https://github.com/apache/airflow/pull/33301#discussion_r1290925610
##########
airflow/utils/setup_teardown.py:
##########
@@ -181,7 +181,10 @@ def _push_tasks(cls, operator: AbstractOperator | list[AbstractOperator], setup:
@classmethod
def _update_teardown_downstream(cls, operator: AbstractOperator | list[AbstractOperator]):
- """This recursively goes through the tasks downstream of the setup in the context manager,
+ """
+ Update _teardown_downstream_of_setup.
Review Comment:
@dstandish Any idea to better describe this function? (Also `_update_setup_upstream` below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #33301: D205 Support - Stragglers
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #33301:
URL: https://github.com/apache/airflow/pull/33301#discussion_r1293728068
##########
airflow/utils/setup_teardown.py:
##########
@@ -181,7 +181,10 @@ def _push_tasks(cls, operator: AbstractOperator | list[AbstractOperator], setup:
@classmethod
def _update_teardown_downstream(cls, operator: AbstractOperator | list[AbstractOperator]):
- """This recursively goes through the tasks downstream of the setup in the context manager,
+ """
+ Update _teardown_downstream_of_setup.
Review Comment:
I think I've found suitable phrasing here and for the other method below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #33301: D205 Support - Stragglers
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #33301:
URL: https://github.com/apache/airflow/pull/33301#issuecomment-1674165055
```
error An unexpected error occurred: "https://registry.yarnpkg.com/@webassemblyjs/helper-wasm-bytecode/-/helper-wasm-bytecode-1.11.1.tgz: Request failed \"500 Internal Server Error\"".
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #33301: D205 Support - Stragglers
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #33301:
URL: https://github.com/apache/airflow/pull/33301#discussion_r1290925610
##########
airflow/utils/setup_teardown.py:
##########
@@ -181,7 +181,10 @@ def _push_tasks(cls, operator: AbstractOperator | list[AbstractOperator], setup:
@classmethod
def _update_teardown_downstream(cls, operator: AbstractOperator | list[AbstractOperator]):
- """This recursively goes through the tasks downstream of the setup in the context manager,
+ """
+ Update _teardown_downstream_of_setup.
Review Comment:
@dstandish Any idea to better describe this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #33301: D205 Support - Stragglers
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #33301:
URL: https://github.com/apache/airflow/pull/33301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org