You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/02/13 11:49:40 UTC

Review Request 56596: Admin View: issues with Users/Groups table filters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56596/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-19982
    https://issues.apache.org/jira/browse/AMBARI-19982


Repository: ambari


Description
-------

1. 'Clear filters' link for Users and Groups tables in Admin View is displayed even if no filter is enabled.
2. Clearing filters on Groups table results in displaying Users table.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 3737414 
  ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 42fb453 

Diff: https://reviews.apache.org/r/56596/diff/


Testing
-------

Executed 80 of 80 SUCCESS (0.413 secs / 0.408 secs)


Thanks,

Andriy Babiichuk


Re: Review Request 56596: Admin View: issues with Users/Groups table filters

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56596/#review165312
-----------------------------------------------------------


Ship it!




Ship It!

- Andrii Tkach


On Feb. 13, 2017, 11:49 a.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56596/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 11:49 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-19982
>     https://issues.apache.org/jira/browse/AMBARI-19982
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. 'Clear filters' link for Users and Groups tables in Admin View is displayed even if no filter is enabled.
> 2. Clearing filters on Groups table results in displaying Users table.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 3737414 
>   ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js 42fb453 
> 
> Diff: https://reviews.apache.org/r/56596/diff/
> 
> 
> Testing
> -------
> 
> Executed 80 of 80 SUCCESS (0.413 secs / 0.408 secs)
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>