You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/10/21 04:16:15 UTC

Review Request 26964: ADDITIONAL_FIX. Rolling Upgrades - hdfs:///apps/tez/tez.tar.gz needs to be versioned

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26964/
-----------------------------------------------------------

Review request for Ambari, jun aoki, Jonathan Hurley, Sumit Mohanty, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-7825
    https://issues.apache.org/jira/browse/AMBARI-7825


Repository: ambari


Description
-------


Additional fix for patch already committed for AMBARI-7825.

Function needs to return a string instead of an int.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py dac524a 

Diff: https://reviews.apache.org/r/26964/diff/


Testing
-------

Deployed a cluster and noticed the error.
Then reran the script to install Tez and it worked.

Ran unit tests inside ambari-server:

----------------------------------------------------------------------
Total run:665
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 26964: ADDITIONAL_FIX. Rolling Upgrades - hdfs:///apps/tez/tez.tar.gz needs to be versioned

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26964/#review57534
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Oct. 21, 2014, 2:35 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26964/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 2:35 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Jonathan Hurley, Sumit Mohanty, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7825
>     https://issues.apache.org/jira/browse/AMBARI-7825
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Additional fix for patch already committed for AMBARI-7825.
> 
> Function needs to return a string instead of an int.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py dac524a 
> 
> Diff: https://reviews.apache.org/r/26964/diff/
> 
> 
> Testing
> -------
> 
> Deployed a cluster and noticed the error.
> Then reran the script to install Tez and it worked.
> 
> Ran unit tests inside ambari-server:
> 
> ----------------------------------------------------------------------
> Total run:665
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 26964: ADDITIONAL_FIX. Rolling Upgrades - hdfs:///apps/tez/tez.tar.gz needs to be versioned

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26964/#review57535
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Oct. 21, 2014, 2:35 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26964/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 2:35 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Jonathan Hurley, Sumit Mohanty, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7825
>     https://issues.apache.org/jira/browse/AMBARI-7825
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Additional fix for patch already committed for AMBARI-7825.
> 
> Function needs to return a string instead of an int.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py dac524a 
> 
> Diff: https://reviews.apache.org/r/26964/diff/
> 
> 
> Testing
> -------
> 
> Deployed a cluster and noticed the error.
> Then reran the script to install Tez and it worked.
> 
> Ran unit tests inside ambari-server:
> 
> ----------------------------------------------------------------------
> Total run:665
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 26964: ADDITIONAL_FIX. Rolling Upgrades - hdfs:///apps/tez/tez.tar.gz needs to be versioned

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26964/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 2:35 a.m.)


Review request for Ambari, jun aoki, Jonathan Hurley, Sumit Mohanty, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-7825
    https://issues.apache.org/jira/browse/AMBARI-7825


Repository: ambari


Description
-------


Additional fix for patch already committed for AMBARI-7825.

Function needs to return a string instead of an int.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py dac524a 

Diff: https://reviews.apache.org/r/26964/diff/


Testing
-------

Deployed a cluster and noticed the error.
Then reran the script to install Tez and it worked.

Ran unit tests inside ambari-server:

----------------------------------------------------------------------
Total run:665
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 26964: ADDITIONAL_FIX. Rolling Upgrades - hdfs:///apps/tez/tez.tar.gz needs to be versioned

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26964/#review57532
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py
<https://reviews.apache.org/r/26964/#comment98265>

    Want to add a comment about the "" return value condition?


- Yusaku Sako


On Oct. 21, 2014, 2:16 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26964/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 2:16 a.m.)
> 
> 
> Review request for Ambari, jun aoki, Jonathan Hurley, Sumit Mohanty, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7825
>     https://issues.apache.org/jira/browse/AMBARI-7825
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Additional fix for patch already committed for AMBARI-7825.
> 
> Function needs to return a string instead of an int.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py dac524a 
> 
> Diff: https://reviews.apache.org/r/26964/diff/
> 
> 
> Testing
> -------
> 
> Deployed a cluster and noticed the error.
> Then reran the script to install Tez and it worked.
> 
> Ran unit tests inside ambari-server:
> 
> ----------------------------------------------------------------------
> Total run:665
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>