[jira] [Commented] (FELIX-2436) Reduce the number files created by the fileinstall Scanner.

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458696#comment-13458696 ] 

Guillaume Nodet commented on FELIX-2436:
----------------------------------------

It seems we have a much better solution now using https://blogs.oracle.com/thejavatutorials/entry/watching_a_directory_for_changes
                
> Reduce the number files created by the fileinstall Scanner.
> -----------------------------------------------------------
>
>                 Key: FELIX-2436
>                 URL: https://issues.apache.org/jira/browse/FELIX-2436
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-2.0.8
>            Reporter: Peter Lawrey
>         Attachments: reduce_object_construction.patch
>
>
> The fileinstaller is called regularly and there can be two or more instances in a server.
> However its object allocation doesn't considered that 99.999+% of the time none of the files change. 
> (polling one per second and changing files once per day is means the file installer will see a change 0.001% of the time)
> In our application, polling every second results in the Scanner creating more objects than the application itself. We can turn down the polling rate but even at once every 10s it creates more objects than any other component!
> For this reason I have changed the Scanner to first check whether any files have changed attempting to compute what has changed.
> See atached for a patch of the changes.  This reduces the number of obejcts created by atleast a factor of 3.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira