You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cramja <gi...@git.apache.org> on 2017/02/21 16:35:14 UTC
[GitHub] incubator-quickstep pull request #189: patches for missed linenoise changes
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/189
patches for missed linenoise changes
This fixes an issue where newlines were not being given to quickstep's parser. These changes existed previously in quickstep but were not carried over in #166
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cramja/incubator-quickstep fix-ln
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
----
commit 1572762a666c1b61b1172beba6d67d3fef5a3a6b
Author: cramja <ma...@gmail.com>
Date: 2017-02-21T16:22:14Z
patches for missed linenoise changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
LGTM. Thanks @cramja for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #189: patches for missed linenoise changes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@cramja The patch has trailing whitespaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@jianqiao This does not fix the bug with `\analyze`. That appears to be something with how the analyze command was written.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@cramja In addition to `\analyze`, it seems that other commands like `\d` and `\dt` also do not work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@zuyu yes it fixed the multiple queries issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
Never mind. It works after resetting the third party and recompiling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@cramja Did this PR fix the issue that the cli shell does not work with a input file with multiple queries?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #189: patches for missed linenoise changes
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/189
@zuyu I cannot recreate the issue you are describing.
```
Starting Quickstep with 8 worker thread(s) and a 11.20 GB buffer pool.
--num_workers is 8, but only specified 0 CPU affinities with --worker_affinities. 8 workers will be unaffinitized.
quickstep> \d
quickstep> \dt
quickstep> \dt foo
ERROR: Unrecognized relation foo (1 : 5)
\dt foo
^
quickstep> create table foo (id int);
Time: 0.205 ms
quickstep> \d
List of relations
Name | Type | Blocks
+-------+-------+---------+
foo | table | 0
quickstep> \dt foo
List of relations
Name | Type | Blocks
+-------+-------+---------+
foo | table | 0
quickstep> \d foo
Table "foo"
Column | Type
+-------+-------+
id | Int
quickstep> \d foobar
ERROR: Unrecognized relation foobar (1 : 4)
\d foobar
^
quickstep> \d
List of relations
Name | Type | Blocks
+-------+-------+---------+
foo | table | 0
quickstep> quit;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---