You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/14 09:11:16 UTC
[GitHub] [iceberg] yohengyangyang opened a new pull request #3742: Core: Reading manifetsFiles parallel when ManifestGroup#planFiles
yohengyangyang opened a new pull request #3742:
URL: https://github.com/apache/iceberg/pull/3742
https://github.com/apache/iceberg/issues/3741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3742: Core: Reading manifetsFiles parallel with ManifestGroup#planFiles
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3742:
URL: https://github.com/apache/iceberg/pull/3742#discussion_r786997535
##########
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##########
@@ -180,43 +202,24 @@ ManifestGroup planWith(ExecutorService newExecutorService) {
return CloseableIterable.transform(entries, e -> new BaseFileScanTask(
e.file().copy(), deleteFiles.forEntry(e), schemaString, specString, residuals));
}
- });
-
- if (executorService != null) {
- return new ParallelIterable<>(tasks, executorService);
- } else {
- return CloseableIterable.concat(tasks);
- }
+ };
}
- /**
- * Returns an iterable for manifest entries in the set of manifests.
- * <p>
- * Entries are not copied and it is the caller's responsibility to make defensive copies if
- * adding these entries to a collection.
- *
- * @return a CloseableIterable of manifest entries.
- */
public CloseableIterable<ManifestEntry<DataFile>> entries() {
return CloseableIterable.concat(entries((manifest, entries) -> entries));
}
- private <T> Iterable<CloseableIterable<T>> entries(
- BiFunction<ManifestFile, CloseableIterable<ManifestEntry<DataFile>>, CloseableIterable<T>> entryFn) {
Review comment:
@yohengyang, please revert all of the whitespace and non-functional changes. Otherwise, we can't really review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org