[GitHub] [arrow-datafusion] mbrobbel commented on a diff in pull request #5707: Upgrade to substrait 0.5.1 and set the version field of produced plans

["mbrobbel (via GitHub)" <gi...@apache.org>]

mbrobbel commented on code in PR #5707:
URL: https://github.com/apache/arrow-datafusion/pull/5707#discussion_r1147398166


##########
datafusion/substrait/src/logical_plan/producer.rs:
##########


Review Comment:
   This is what `rustfmt` made of it after adding a use statement for the `version` mod.
   
   I would not recommend using unstable configuration options for `rustfmt`.



##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -80,7 +83,7 @@ pub fn to_substrait_plan(plan: &LogicalPlan) -> Result<Box<Plan>> {
 
     // Return parsed plan
     Ok(Box::new(Plan {
-        version: None, // TODO: https://github.com/apache/arrow-datafusion/issues/4949
+        version: Some(version::version_with_producer("datafusion")),

Review Comment:
   No, that is not something that should be encoded in the version field of a plan.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org