You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by John Szakmeister <jo...@szakmeister.net> on 2006/10/22 18:46:40 UTC

Add revision and quiet support to svnadmin verify...

Hello All,

It's been a while since I made a commit, so I'm throwing this out there for review.  It adds support for specifying which revisions to verify and enables quiet support for the 'svnadmin verify' command.  Nothing too exciting, but it has been requested by a couple of users, and I think it's useful.

On a different note, how would you guys feel about adding an 'svnadmin verify -r$REV' step to the default hook script (assuming this patch gets committed)?  One of the problems that I'm constantly seeing is that users fail to run any sort of checks on their repositories... ever.  Then they end up with things like the FSFS corruption, and discover it long after the commit has been made.  Adding a line to the post-commit hook could at least help people take some sort of step, especially when it comes to detecting the FSFS corruption that we've been seeing.  Perhaps even a comment about how to turn on incremental dumps would be a good thing too?

Just a thought.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Add revision and quiet support to svnadmin verify...

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 10/22/06, John Szakmeister <jo...@szakmeister.net> wrote:
> Hello All,
>
> It's been a while since I made a commit, so I'm throwing this out there
> for review.  It adds support for specifying which revisions to verify
> and enables quiet support for the 'svnadmin verify' command.  Nothing
> too exciting, but it has been requested by a couple of users, and I
> think it's useful.

The patch looks fine to me.

> On a different note, how would you guys feel about adding an 'svnadmin
> verify -r$REV' step to the default hook script (assuming this patch
> gets committed)?  One of the problems that I'm constantly seeing is
> that users fail to run any sort of checks on their repositories...
> ever.  Then they end up with things like the FSFS corruption, and
> discover it long after the commit has been made.  Adding a line to the
> post-commit hook could at least help people take some sort of step,
> especially when it comes to detecting the FSFS corruption that we've
> been seeing.  Perhaps even a comment about how to turn on incremental
> dumps would be a good thing too?

Seems reasonable.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Add revision and quiet support to svnadmin verify...

Posted by John Szakmeister <jo...@szakmeister.net>.
----- John Szakmeister <jo...@szakmeister.net> wrote:
> Hello All,
> 
> It's been a while since I made a commit, so I'm throwing this out
> there for review.  It adds support for specifying which revisions to
> verify and enables quiet support for the 'svnadmin verify' command. 
> Nothing too exciting, but it has been requested by a couple of users,
> and I think it's useful.
> 
> On a different note, how would you guys feel about adding an 'svnadmin
> verify -r$REV' step to the default hook script (assuming this patch
> gets committed)?  One of the problems that I'm constantly seeing is
> that users fail to run any sort of checks on their repositories...
> ever.  Then they end up with things like the FSFS corruption, and
> discover it long after the commit has been made.  Adding a line to the
> post-commit hook could at least help people take some sort of step,
> especially when it comes to detecting the FSFS corruption that we've
> been seeing.  Perhaps even a comment about how to turn on incremental
> dumps would be a good thing too?
> 
> Just a thought.

With the patch this time.  Thanks David!

-John