[jira] [Comment Edited] (AMQ-5378) Initscript refactoring: setup function seems to be broken, removal of uneccessary files, fix various problems

["Marc Schöchlin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223381#comment-14223381 ] 

Marc Schöchlin edited comment on AMQ-5378 at 11/24/14 7:49 PM:
---------------------------------------------------------------

[~dejanb] No, i do not own a wiki account. How can i get one? (...where can i find the wiki login)

Have a look at my patches - i fixed various problems i the old script:
- the setup option was broken"bstat,"
- the "bstat" does not throw exception anymore if the broker is not running
- the values of the default configuration creation were improved
- it is now possible to chain various symlinks to the installation/the initscript (also classpath issues)
  /etc/init.d/activemq --> /opt/activemq/current/bin/activemq
  /opt/activemq/current/ --> /opt/activemq/apache-activemq-5.10.0/
- options like create, encrypt and decrypt are now working if the broker is not running
- the help output was improved
- if there is more than one defaults file, only the first one is loaded

I think it would be a huge step back to restart with the inital state.

I thought about the default configuration.  
I think we should not do this, because this renders automatic calculation of the current step to be useless.
The creation of the old defaults file was broken, therefore strange if/then/else constructs were contained in the file created by the "setup" option.

A working init script is a important thing for system administrators, i think it would be a good idea to get the changes upstream in a fast way. 
(Probably it's good idea to write a small integration test suite for the init script)



was (Author: scoopex):
[~dejanb] No, i do not own a wiki account. How can i get one? (...where can i find the wiki login)

Have a look at my patches - i fixed various problems i the old script:
- the setup option was broken"bstat,"
- the "bstat" does not throw exception anymore if the broker is not running
- the values of the default configuration creation were improved
- it is now possible to chain various symlinks to the installation/the initscript (also classpath issues)
  /etc/init.d/activemq --> /opt/activemq/current/bin/activemq
  /opt/activemq/current/ --> /opt/activemq/apache-activemq-5.10.0/
- options like create, encrypt and decrypt are now working if the broker is not running
- the help output was improved
- if there is more than one defaults file, only the first one is loaded

I think it would be a huge step back to restart with the inital state.

I thought about the default configuration.  
I think we should not do this, because this renders automatic calculation of the current step to be useless.
The creation of the old defaults file was broken, therefore strange if/then/else constructs were contained in the file created by the "setup" option.



> Initscript refactoring: setup function seems to be broken, removal of uneccessary files, fix various problems
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-5378
>                 URL: https://issues.apache.org/jira/browse/AMQ-5378
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.10.0
>         Environment: Linux/Unix
>            Reporter: Marc Schöchlin
>              Labels: assemblies
>             Fix For: 5.11.0
>
>         Attachments: AMQ-5378.patch
>
>
> The current initscript seems to be broken.
> I submitted the current unix init script (see AMQ-2453) - the original script seems to be modified in a way which breaks the "setup" function
> If you call "./activemq setup ~/.activemq" you get a really messy configfile.
> The current distribution also contains lots of files of the java service wrapper which are not needed anymore.
> I created the following patch/pull request:
> https://github.com/apache/activemq/pull/46



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)