You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2017/02/27 14:20:24 UTC
[GitHub] zeppelin pull request #2076: ZEPPELIN-2173 Duplicate user names populated in...
GitHub user r-kamath opened a pull request:
https://github.com/apache/zeppelin/pull/2076
ZEPPELIN-2173 Duplicate user names populated in the Note permission box
### What is this PR for?
Duplicate user names populated in the Note permission box
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* [ZEPPELIN-2173](https://issues.apache.org/jira/browse/ZEPPELIN-2173)
### How should this be tested?
See JIRA description for the steps to reproduce the issue.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-2173
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2076
----
commit 14296b4e59fa81066b4d96e2b439adfaa5dcd851
Author: Renjith Kamath <re...@gmail.com>
Date: 2017-02-27T13:53:11Z
ZEPPELIN-2173 Duplicate user names populated in the Note permission box
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2076
Unrelated CI failure for profile 2 and 3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2076: ZEPPELIN-2173 Duplicate user names populated in...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath closed the pull request at:
https://github.com/apache/zeppelin/pull/2076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2076: ZEPPELIN-2173 Duplicate user names populated in...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath closed the pull request at:
https://github.com/apache/zeppelin/pull/2076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2076
@soralee thanks for the review.
> For example, if user who is not permission fail to edit permission, the status of permission is displayed to values before the modification
we will have to handle this in the backend and restrict the users from editing the exiting permissions, may be with some UI modifications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2076
Tested and It works well as that remove duplication name.
But, In my personal opinion, I'd like to suggest that It would be better to show it in its original state. For example, if user who is not permission fail to edit permission, the status of permission is displayed to values before the modification .
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2076
closed and reopened to trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2076: ZEPPELIN-2173 Duplicate user names populated in...
Posted by r-kamath <gi...@git.apache.org>.
GitHub user r-kamath reopened a pull request:
https://github.com/apache/zeppelin/pull/2076
ZEPPELIN-2173 Duplicate user names populated in the Note permission box
### What is this PR for?
Duplicate user names populated in the Note permission box
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* [ZEPPELIN-2173](https://issues.apache.org/jira/browse/ZEPPELIN-2173)
### How should this be tested?
See JIRA description for the steps to reproduce the issue.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-2173
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2076
----
commit 14296b4e59fa81066b4d96e2b439adfaa5dcd851
Author: Renjith Kamath <re...@gmail.com>
Date: 2017-02-27T13:53:11Z
ZEPPELIN-2173 Duplicate user names populated in the Note permission box
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2076: ZEPPELIN-2173 Duplicate user names populated in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2076: ZEPPELIN-2173 Duplicate user names populated in...
Posted by r-kamath <gi...@git.apache.org>.
GitHub user r-kamath reopened a pull request:
https://github.com/apache/zeppelin/pull/2076
ZEPPELIN-2173 Duplicate user names populated in the Note permission box
### What is this PR for?
Duplicate user names populated in the Note permission box
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* [ZEPPELIN-2173](https://issues.apache.org/jira/browse/ZEPPELIN-2173)
### How should this be tested?
See JIRA description for the steps to reproduce the issue.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-2173
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2076
----
commit 14296b4e59fa81066b4d96e2b439adfaa5dcd851
Author: Renjith Kamath <re...@gmail.com>
Date: 2017-02-27T13:53:11Z
ZEPPELIN-2173 Duplicate user names populated in the Note permission box
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2076
@r-kamath Thanks for fixing this issue!
Let me check and give a feedback soon :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2076
Merging this to master and branch-0.7 if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---