You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "zhongjiajie (via GitHub)" <gi...@apache.org> on 2023/02/12 10:55:52 UTC
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie opened a new pull request, #73: feat: Add online_schedule for workflow control schedule state
zhongjiajie opened a new pull request, #73:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/73
<!--Thanks for you contribute to Apache DolphinScheduler Python API, You can see more detail about contributing in https://github.com/apache/dolphinscheduler-sdk-python/DEVELOP.md .-->
## Brief Summary of The Change
<!--Please include `fixes: #XXXX(ISSUE_NUMBER)` to automatically close any corresponding issue when the pull request is merged. Alternatively if not fully closed you can say `related: #XXXX(ISSUE_NUMBER)`.-->
Add parameter `online_schedule` to control whether the schedule is online or not
close: #71
## Pull Request checklist
I confirm that the following checklist has been completed.
- [x] Add/Change **test cases** for the changes.
- [x] Add/Change the related **documentation**, should also change `docs/source/config.rst` when you change file `default_config.yaml`.
- [x] (Optional) Add your change to `UPDATING.md` when it is an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #73: feat: Add online_schedule for workflow control schedule state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #73:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/73#issuecomment-1481064532
> > we still need to change java code in repo apache/dolphinscheduler
>
> submit in [apache/dolphinscheduler#13551](https://github.com/apache/dolphinscheduler/pull/13551)
may release in version apache/dolphinscheduler:3.1.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #73: feat: Add online_schedule for workflow control schedule state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #73:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/73#issuecomment-1427002619
we still need to change java code in repo apache/dolphinscheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #73: feat: Add online_schedule for workflow control schedule state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #73:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/73#issuecomment-1427004258
> we still need to change java code in repo apache/dolphinscheduler
submit in https://github.com/apache/dolphinscheduler/pull/13551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie merged pull request #73: feat: Add online_schedule for workflow control schedule state
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie merged PR #73:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] codecov-commenter commented on pull request #73: feat: Add online_schedule for workflow control schedule state
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #73:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/73#issuecomment-1427002124
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/73?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#73](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/73?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (264e641) into [main](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/fa57d68e87a0f2454a68a89283e787c615d54402?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa57d68) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 90.92% 90.93% +0.01%
==========================================
Files 61 61
Lines 2215 2218 +3
==========================================
+ Hits 2014 2017 +3
Misses 201 201
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `90.93% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/pydolphinscheduler/core/workflow.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3dvcmtmbG93LnB5) | `81.76% <100.00%> (+0.30%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org