You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/10/13 02:24:38 UTC

svn commit: r1021959 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl: StackKeyedObjectPoolFactory.java StackObjectPool.java StackObjectPoolFactory.java

Author: sebb
Date: Wed Oct 13 00:24:37 2010
New Revision: 1021959

URL: http://svn.apache.org/viewvc?rev=1021959&view=rev
Log:
Make private immutable fields final

Modified:
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackKeyedObjectPoolFactory.java
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPool.java
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPoolFactory.java

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackKeyedObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackKeyedObjectPoolFactory.java?rev=1021959&r1=1021958&r2=1021959&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackKeyedObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackKeyedObjectPoolFactory.java Wed Oct 13 00:24:37 2010
@@ -90,7 +90,7 @@ public class StackKeyedObjectPoolFactory
     /**
      * Initial capacity of StackKeyedObjectPools created by this factory.
      */
-    private int _initCapacity = StackKeyedObjectPool.DEFAULT_INIT_SLEEPING_CAPACITY;
+    private final int _initCapacity;
 
     /**
      * Returns the KeyedPoolableObjectFactory used by StackKeyedObjectPools created by this factory

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPool.java?rev=1021959&r1=1021958&r2=1021959&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPool.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPool.java Wed Oct 13 00:24:37 2010
@@ -347,7 +347,7 @@ public class StackObjectPool<T> extends 
     /** 
      * My pool. 
      */
-    private Stack<T> _pool = null;
+    private final Stack<T> _pool;
 
     /** 
      * My {@link PoolableObjectFactory}.

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPoolFactory.java?rev=1021959&r1=1021958&r2=1021959&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPoolFactory.java Wed Oct 13 00:24:37 2010
@@ -87,7 +87,7 @@ public class StackObjectPoolFactory<T> i
     /**
      * The initial size of created pools.
      */
-    private int _initCapacity = StackObjectPool.DEFAULT_INIT_SLEEPING_CAPACITY;
+    private final int _initCapacity;
 
     /**
      * Returns the factory used by created pools.