You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2020/01/27 09:22:07 UTC
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/
-----------------------------------------------------------
(Updated Jan. 27, 2020, 9:22 a.m.)
Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2670
https://issues.apache.org/jira/browse/RANGER-2670
Repository: ranger
Description
-------
1) Bookmark functionality for Report and Encryption tab.
2) Audit tab :
* sortBy and sortOrder are in query-params (All Tab).
* plugin-status page to highlight the plugins not having the latest policies.
* clicking on an audit entry to show a pop-up with audit log details.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
security-admin/src/main/webapp/styles/xa.css f75facb
security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
Diff: https://reviews.apache.org/r/72001/diff/3/
Testing (updated)
-------
1.Checked bookmark functionality is working for unzone and zone policy listing page.
2.Checked bookmark functionality is working for audit page.
3.Checked bookmark functionality is working for user/role listing page.
4.Checked bookmark functionality is working for permission page.
In this patch, two new functionality added.
1) In Audit ==>> Access tab
=> When we click on policy ID column its open Policy details popup.
=> When we click other than policy ID column its open Access log details popup.
2) In Audit ==>> Plugin Status
Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
=> Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
=> Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
Thanks,
Nitin Galave
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/#review219409
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
Lines 1756 (patched)
<https://reviews.apache.org/r/72001/#comment307575>
any specific reason to use StringUtils.isBlank() here and StringUtils.isEmpty() at line 1866.
security-admin/src/main/webapp/scripts/utils/XAUtils.js
Lines 1867 (patched)
<https://reviews.apache.org/r/72001/#comment307576>
check spelling
security-admin/src/main/webapp/scripts/utils/XAUtils.js
Lines 1876 (patched)
<https://reviews.apache.org/r/72001/#comment307577>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js
Lines 63 (patched)
<https://reviews.apache.org/r/72001/#comment307579>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 1461 (patched)
<https://reviews.apache.org/r/72001/#comment307580>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 1588 (patched)
<https://reviews.apache.org/r/72001/#comment307581>
check spelling
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js
Line 33 (original), 33 (patched)
<https://reviews.apache.org/r/72001/#comment307582>
whats the name represents here
- Pradeep Agrawal
On Jan. 27, 2020, 9:22 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72001/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2020, 9:22 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2670
> https://issues.apache.org/jira/browse/RANGER-2670
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1) Bookmark functionality for Report and Encryption tab.
> 2) Audit tab :
> * sortBy and sortOrder are in query-params (All Tab).
> * plugin-status page to highlight the plugins not having the latest policies.
> * clicking on an audit entry to show a pop-up with audit log details.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
> security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
> security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
> security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
> security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
> security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
> security-admin/src/main/webapp/styles/xa.css f75facb
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
>
>
> Diff: https://reviews.apache.org/r/72001/diff/3/
>
>
> Testing
> -------
>
> 1.Checked bookmark functionality is working for unzone and zone policy listing page.
> 2.Checked bookmark functionality is working for audit page.
> 3.Checked bookmark functionality is working for user/role listing page.
> 4.Checked bookmark functionality is working for permission page.
>
> In this patch, two new functionality added.
> 1) In Audit ==>> Access tab
> => When we click on policy ID column its open Policy details popup.
> => When we click other than policy ID column its open Access log details popup.
>
> 2) In Audit ==>> Plugin Status
> Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
> => Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
> => Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/#review219435
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Jan. 29, 2020, 11:45 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72001/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2020, 11:45 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2670
> https://issues.apache.org/jira/browse/RANGER-2670
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1) Bookmark functionality for Report and Encryption tab.
> 2) Audit tab :
> * sortBy and sortOrder are in query-params (All Tab).
> * plugin-status page to highlight the plugins not having the latest policies.
> * clicking on an audit entry to show a pop-up with audit log details.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
> security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
> security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
> security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
> security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
> security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
> security-admin/src/main/webapp/styles/xa.css f75facb
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
>
>
> Diff: https://reviews.apache.org/r/72001/diff/5/
>
>
> Testing
> -------
>
> 1.Checked bookmark functionality is working for unzone and zone policy listing page.
> 2.Checked bookmark functionality is working for audit page.
> 3.Checked bookmark functionality is working for user/role listing page.
> 4.Checked bookmark functionality is working for permission page.
>
> In this patch, two new functionality added.
> 1) In Audit ==>> Access tab
> => When we click on policy ID column its open Policy details popup.
> => When we click other than policy ID column its open Access log details popup.
>
> 2) In Audit ==>> Plugin Status
> Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
> => Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
> => Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Nitin Galave <ni...@gmail.com>.
> On Jan. 29, 2020, 11:55 a.m., Pradeep Agrawal wrote:
> > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
> > Line 1937 (original), 2061 (patched)
> > <https://reviews.apache.org/r/72001/diff/4/?file=2209934#file2209934line2069>
> >
> > what is 36e5 ?
The subtraction returns the difference between the two dates in milliseconds. 36e5 is the scientific notation for 60*60*1000, dividing by which converts the milliseconds difference into hours.
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/#review219413
-----------------------------------------------------------
On Jan. 29, 2020, 11:45 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72001/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2020, 11:45 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2670
> https://issues.apache.org/jira/browse/RANGER-2670
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1) Bookmark functionality for Report and Encryption tab.
> 2) Audit tab :
> * sortBy and sortOrder are in query-params (All Tab).
> * plugin-status page to highlight the plugins not having the latest policies.
> * clicking on an audit entry to show a pop-up with audit log details.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
> security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
> security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
> security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
> security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
> security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
> security-admin/src/main/webapp/styles/xa.css f75facb
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
>
>
> Diff: https://reviews.apache.org/r/72001/diff/5/
>
>
> Testing
> -------
>
> 1.Checked bookmark functionality is working for unzone and zone policy listing page.
> 2.Checked bookmark functionality is working for audit page.
> 3.Checked bookmark functionality is working for user/role listing page.
> 4.Checked bookmark functionality is working for permission page.
>
> In this patch, two new functionality added.
> 1) In Audit ==>> Access tab
> => When we click on policy ID column its open Policy details popup.
> => When we click other than policy ID column its open Access log details popup.
>
> 2) In Audit ==>> Plugin Status
> Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
> => Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
> => Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/#review219413
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 952 (patched)
<https://reviews.apache.org/r/72001/#comment307585>
check spelling. is it working ?
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Line 1164 (original), 1217 (patched)
<https://reviews.apache.org/r/72001/#comment307586>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 1461 (patched)
<https://reviews.apache.org/r/72001/#comment307587>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 1588 (patched)
<https://reviews.apache.org/r/72001/#comment307588>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 1954 (patched)
<https://reviews.apache.org/r/72001/#comment307589>
check spelling
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Line 1937 (original), 2061 (patched)
<https://reviews.apache.org/r/72001/#comment307590>
what is 36e5 ?
- Pradeep Agrawal
On Jan. 29, 2020, 11:45 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72001/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2020, 11:45 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2670
> https://issues.apache.org/jira/browse/RANGER-2670
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1) Bookmark functionality for Report and Encryption tab.
> 2) Audit tab :
> * sortBy and sortOrder are in query-params (All Tab).
> * plugin-status page to highlight the plugins not having the latest policies.
> * clicking on an audit entry to show a pop-up with audit log details.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
> security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
> security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
> security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
> security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
> security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
> security-admin/src/main/webapp/styles/xa.css f75facb
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
>
>
> Diff: https://reviews.apache.org/r/72001/diff/5/
>
>
> Testing
> -------
>
> 1.Checked bookmark functionality is working for unzone and zone policy listing page.
> 2.Checked bookmark functionality is working for audit page.
> 3.Checked bookmark functionality is working for user/role listing page.
> 4.Checked bookmark functionality is working for permission page.
>
> In this patch, two new functionality added.
> 1) In Audit ==>> Access tab
> => When we click on policy ID column its open Policy details popup.
> => When we click other than policy ID column its open Access log details popup.
>
> 2) In Audit ==>> Plugin Status
> Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
> => Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
> => Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/#review219418
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On Jan. 29, 2020, 11:45 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72001/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2020, 11:45 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2670
> https://issues.apache.org/jira/browse/RANGER-2670
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1) Bookmark functionality for Report and Encryption tab.
> 2) Audit tab :
> * sortBy and sortOrder are in query-params (All Tab).
> * plugin-status page to highlight the plugins not having the latest policies.
> * clicking on an audit entry to show a pop-up with audit log details.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
> security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
> security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
> security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
> security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
> security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
> security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
> security-admin/src/main/webapp/styles/xa.css f75facb
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
>
>
> Diff: https://reviews.apache.org/r/72001/diff/5/
>
>
> Testing
> -------
>
> 1.Checked bookmark functionality is working for unzone and zone policy listing page.
> 2.Checked bookmark functionality is working for audit page.
> 3.Checked bookmark functionality is working for user/role listing page.
> 4.Checked bookmark functionality is working for permission page.
>
> In this patch, two new functionality added.
> 1) In Audit ==>> Access tab
> => When we click on policy ID column its open Policy details popup.
> => When we click other than policy ID column its open Access log details popup.
>
> 2) In Audit ==>> Plugin Status
> Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
> => Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
> => Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/
-----------------------------------------------------------
(Updated Jan. 29, 2020, 11:45 a.m.)
Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2670
https://issues.apache.org/jira/browse/RANGER-2670
Repository: ranger
Description
-------
1) Bookmark functionality for Report and Encryption tab.
2) Audit tab :
* sortBy and sortOrder are in query-params (All Tab).
* plugin-status page to highlight the plugins not having the latest policies.
* clicking on an audit entry to show a pop-up with audit log details.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
security-admin/src/main/webapp/styles/xa.css f75facb
security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
Diff: https://reviews.apache.org/r/72001/diff/5/
Changes: https://reviews.apache.org/r/72001/diff/4-5/
Testing
-------
1.Checked bookmark functionality is working for unzone and zone policy listing page.
2.Checked bookmark functionality is working for audit page.
3.Checked bookmark functionality is working for user/role listing page.
4.Checked bookmark functionality is working for permission page.
In this patch, two new functionality added.
1) In Audit ==>> Access tab
=> When we click on policy ID column its open Policy details popup.
=> When we click other than policy ID column its open Access log details popup.
2) In Audit ==>> Plugin Status
Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
=> Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
=> Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
Thanks,
Nitin Galave
Re: Review Request 72001: RANGER-2670 : Bookmark functionality for
Report Tab and Add sort By query param in URL.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/
-----------------------------------------------------------
(Updated Jan. 29, 2020, 11:38 a.m.)
Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2670
https://issues.apache.org/jira/browse/RANGER-2670
Repository: ranger
Description
-------
1) Bookmark functionality for Report and Encryption tab.
2) Audit tab :
* sortBy and sortOrder are in query-params (All Tab).
* plugin-status page to highlight the plugins not having the latest policies.
* clicking on an audit entry to show a pop-up with audit log details.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 38884c7
security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 8e24b71
security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 8b7a68d
security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a559248
security-admin/src/main/webapp/scripts/routers/Router.js 14f4916
security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f
security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 798fe79
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 4ee9487
security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 5672552
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js d1f421f
security-admin/src/main/webapp/styles/xa.css f75facb
security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html befb230
Diff: https://reviews.apache.org/r/72001/diff/4/
Changes: https://reviews.apache.org/r/72001/diff/3-4/
Testing
-------
1.Checked bookmark functionality is working for unzone and zone policy listing page.
2.Checked bookmark functionality is working for audit page.
3.Checked bookmark functionality is working for user/role listing page.
4.Checked bookmark functionality is working for permission page.
In this patch, two new functionality added.
1) In Audit ==>> Access tab
=> When we click on policy ID column its open Policy details popup.
=> When we click other than policy ID column its open Access log details popup.
2) In Audit ==>> Plugin Status
Highlight policy/tag download/active cells when they are behind the ‘Last Update’ time.
=> Red: If ‘Last Update’ >= 2min of download/active in Policy(Time)/tag(Time) details.
=> Yellow: If ‘Last Update’ < 2min of download/active in Policy(Time)/tag(Time) details.
Thanks,
Nitin Galave