You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/02 03:00:06 UTC
[GitHub] rafaelweingartner commented on a change in pull request #2870: KVM
HyperV Enlightment for Improved Windows Server 2008+ Performance
rafaelweingartner commented on a change in pull request #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance
URL: https://github.com/apache/cloudstack/pull/2870#discussion_r221814104
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2101,14 +2101,17 @@ So if getMinSpeed() returns null we fall back to getSpeed().
features.addFeatures("pae");
features.addFeatures("apic");
features.addFeatures("acpi");
- //for rhel 6.5 and above, hyperv enlightment feature is added
- /*
- * if (vmTO.getOs().contains("Windows Server 2008") && hostOsVersion != null && ((hostOsVersion.first() == 6 && hostOsVersion.second() >= 5) || (hostOsVersion.first() >= 7))) {
- * LibvirtVMDef.HyperVEnlightenmentFeatureDef hyv = new LibvirtVMDef.HyperVEnlightenmentFeatureDef();
- * hyv.setRelaxed(true);
- * features.addHyperVFeature(hyv);
- * }
- */
+ //for rhel 6.5 and above, hyperv enlightenment feature is added
Review comment:
Thanks for the PR @kiwiflyer!
Would you mind extracting the code 2105-2114 to a method, document it, and then create a unit test case?
This `createVMFromSpec` is too big already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services