You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/05 12:13:20 UTC

[GitHub] [airflow] rachael-ds opened a new issue #14097: Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)

rachael-ds opened a new issue #14097:
URL: https://github.com/apache/airflow/issues/14097


   Typo in Google Cloud Storage sensor: airflow/providers/google/cloud/sensors/gcs/GCSObjectsWithPrefixExistenceSensor
   
   The word _With_ is spelled incorrectly. It should be: GCSObjects**With**PrefixExistenceSensor
   
   **Apache Airflow version**: 2.0.0
   **Environment**:
   - **Cloud provider or hardware configuration**: Google Cloud
   - **OS** (e.g. from /etc/os-release): Mac OS BigSur
   
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] rachael-ds commented on issue #14097: Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)

Posted by GitBox <gi...@apache.org>.
rachael-ds commented on issue #14097:
URL: https://github.com/apache/airflow/issues/14097#issuecomment-776562888


   I haven't started on this - please go ahead thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #14097: Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #14097:
URL: https://github.com/apache/airflow/issues/14097#issuecomment-774357371


   You should change the name and then add the code below for backward compatibility.
   ```
   class GCSObjectsWtihPrefixExistenceSensor(GCSObjectsWithPrefixExistenceSensor):
       """
       This class is deprecated.
       Please use `airflow.providers.google.cloud.sensors.gcs.GCSObjectsWithPrefixExistenceSensor`.
       """
   
       def __init__(self, *args, **kwargs):
           warnings.warn(
               """This class is deprecated.
               Please use `airflow.providers.google.cloud.sensors.gcs.GCSObjectsWithPrefixExistenceSensor`.""",
               DeprecationWarning,
               stacklevel=3,
           )
           super().__init__(*args, **kwargs)
   ```
   It is also worth adding tests. To do it, update the [`deprecated_classes.py`](https://github.com/apache/airflow/blob/master/tests/deprecated_classes.py) file.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #14097: Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #14097:
URL: https://github.com/apache/airflow/issues/14097#issuecomment-773996592


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] morrme commented on issue #14097: Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)

Posted by GitBox <gi...@apache.org>.
morrme commented on issue #14097:
URL: https://github.com/apache/airflow/issues/14097#issuecomment-776262925


   @rachael-ds Are you working to fix this? If not, I'd like to submit a fix. 
   
   cc: @vikramkoka @mik-laj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek closed issue #14097: Typo in Sensor: GCSObjectsWtihPrefixExistenceSensor (should be GCSObjectsWithPrefixExistenceSensor)

Posted by GitBox <gi...@apache.org>.
turbaszek closed issue #14097:
URL: https://github.com/apache/airflow/issues/14097


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org