[GitHub] [drill] vvysotskyi commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r320043141
 
 

 ##########
 File path: exec/vector/src/main/java/org/apache/drill/exec/expr/holders/RepeatedValueHolder.java
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.expr.holders;
+
+import org.apache.drill.exec.vector.ValueVector;
+import org.apache.drill.exec.vector.complex.reader.FieldReader;
+
+public abstract class RepeatedValueHolder<V extends ValueVector> implements ValueHolder {
+
+  /** The first index (inclusive) into the Vector. **/
+  public int start;
+
+  /** The last index (exclusive) into the Vector. **/
+  public int end;
+
+  /** The Vector holding the actual values. **/
+  public V vector;
 
 Review comment:
   Generics usage in `ValueHolder` class may be risky. Could you please confirm that there are no issues for bot JDK and Janino compilers for the code with generics?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services