You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/03/23 11:51:58 UTC
Review Request 57873: There is invalid clause in the installer for
Install and Configure Solr for Ranger Audits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57873/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1473
https://issues.apache.org/jira/browse/RANGER-1473
Repository: ranger
Description
-------
The installer used the RANGER_AUDITS_DATA_FOLDER attribute value in Install and Configure Solr for Ranger Audits. The intention of the installer is to replace the value of the RANGER_AUDITS_DATA_FOLDER in dataDir=RANGER_AUDITS_DATA_FOLDER of core.properties.j2. So we should remove invalid clause.
Diffs
-----
security-admin/contrib/solr_for_audit_setup/setup.sh 99a3086
Diff: https://reviews.apache.org/r/57873/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 57873: There is invalid clause in the installer for
Install and Configure Solr for Ranger Audits
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57873/#review169948
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On \u4e09\u6708 23, 2017, 2:13 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57873/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 23, 2017, 2:13 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1473
> https://issues.apache.org/jira/browse/RANGER-1473
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The installer used the RANGER_AUDITS_DATA_FOLDER attribute value in Install and Configure Solr for Ranger Audits. There is no RANGER_AUDITS_DATA_FOLDER attribute in install.properties. In the following clause the intention of the installer is to replace the value of the RANGER_AUDITS_DATA_FOLDER in dataDir=RANGER_AUDITS_DATA_FOLDER of core.properties.j2. So we should remove invalid clause.
> sed "s#{{RANGER_AUDITS_DATA_FOLDER}}#$SOLR_RANGER_DATA_FOLDER#g" $SOLR_RANGER_HOME/${SOLR_RANGER_COLLECTION}/core.properties.j2 > $SOLR_RANGER_HOME/${SOLR_RANGER_COLLECTION}/core.properties
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 99a3086
>
>
> Diff: https://reviews.apache.org/r/57873/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 57873: There is invalid clause in the installer for
Install and Configure Solr for Ranger Audits
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57873/
-----------------------------------------------------------
(Updated \u4e09\u6708 23, 2017, 2:13 p.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1473
https://issues.apache.org/jira/browse/RANGER-1473
Repository: ranger
Description (updated)
-------
The installer used the RANGER_AUDITS_DATA_FOLDER attribute value in Install and Configure Solr for Ranger Audits. There is no RANGER_AUDITS_DATA_FOLDER attribute in install.properties. In the following clause the intention of the installer is to replace the value of the RANGER_AUDITS_DATA_FOLDER in dataDir=RANGER_AUDITS_DATA_FOLDER of core.properties.j2. So we should remove invalid clause.
sed "s#{{RANGER_AUDITS_DATA_FOLDER}}#$SOLR_RANGER_DATA_FOLDER#g" $SOLR_RANGER_HOME/${SOLR_RANGER_COLLECTION}/core.properties.j2 > $SOLR_RANGER_HOME/${SOLR_RANGER_COLLECTION}/core.properties
Diffs
-----
security-admin/contrib/solr_for_audit_setup/setup.sh 99a3086
Diff: https://reviews.apache.org/r/57873/diff/1/
Testing
-------
Thanks,
pengjianhua