[GitHub] [griffin] chemikadze commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

[GitBox <gi...@apache.org>]

chemikadze commented on a change in pull request #492: GRIFFIN-244 get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271557391
 
 

 ##########
 File path: service/src/main/java/org/apache/griffin/core/metric/model/MetricValue.java
 ##########
 @@ -61,4 +72,38 @@ public void setTmst(Long tmst) {
     public void setValue(Map<String, Object> value) {
         this.value = value;
     }
+
+    public String getApplicationId() {
 
 Review comment:
   Suddenly I've realized that probably more extensible way would be to have "metadata" map on metric, instead of fixed "applicationId" value. Who knows what can be useful later.
   
   I know that applicationId is already part of the code base, but as it's not read from anywhere and we did not release that code, it can be right moment to change it. But later we'll be at point of no return.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services