You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/08/17 02:15:54 UTC
[GitHub] [tomcat] YunLemon opened a new pull request #445: Improve Travis CI build Performance
YunLemon opened a new pull request #445:
URL: https://github.com/apache/tomcat/pull/445
According to [Build times out because no output was received](https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received), we should carefully use travis_wait, as it may make the build unstable and extend the build time.
[Caching Dependencies and Directories](https://docs.travis-ci.com/user/caching/) Travis CI can cache content that does not often change, to speed up the build process.
=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690177540
##########
File path: .travis.yml
##########
@@ -80,7 +80,7 @@ install:
script:
- ant -q clean
- - travis_wait 120 "./.travis/antTest.sh"
+ - "./.travis/antTest.sh"
Review comment:
I cannot say how long it might take. It depends on how loaded the Travis VM is. Sometimes jobs take twenty something minutes, sometimes fifty something minutes...
According to https://docs.travis-ci.com/user/customizing-the-build/#sts=Build%20Timeouts the max timeout for a job should be 50 mins, but it seems `travis_wait` may extend it. I cannot find any reference in their docs for its maximum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690160756
##########
File path: .travis.yml
##########
@@ -90,3 +90,6 @@ after_failure:
notifications:
email:
- dev@tomcat.apache.org
+cache:
+ directories:
+ - $HOME/.m2
Review comment:
Tomcat does not use Maven so I see no reason to cache this folder.
##########
File path: .travis.yml
##########
@@ -80,7 +80,7 @@ install:
script:
- ant -q clean
- - travis_wait 120 "./.travis/antTest.sh"
+ - "./.travis/antTest.sh"
Review comment:
https://app.travis-ci.com/github/apache/tomcat/jobs/531899762 (the build for this PR) fails with `No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.`. So yes, `travis_wait` is needed!
Maybe the duration should be reduced though.
AFAIK Travis jobs could run for at most 50 mins but I see some which succeeded even after that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #445:
URL: https://github.com/apache/tomcat/pull/445#issuecomment-900129327
It doesn't. It won't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #445:
URL: https://github.com/apache/tomcat/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690180710
##########
File path: .travis.yml
##########
@@ -90,3 +90,6 @@ after_failure:
notifications:
email:
- dev@tomcat.apache.org
+cache:
+ directories:
+ - $HOME/.m2
Review comment:
Or maybe the ones in https://github.com/apache/tomcat/blob/main/modules/ ?
I am not sure whether Ant executes those. So the cache might be useful after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] YunLemon commented on a change in pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
YunLemon commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690167527
##########
File path: .travis.yml
##########
@@ -90,3 +90,6 @@ after_failure:
notifications:
email:
- dev@tomcat.apache.org
+cache:
+ directories:
+ - $HOME/.m2
Review comment:
I add this because I see this repo contains pom.xml....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] YunLemon commented on a change in pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
YunLemon commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690172550
##########
File path: .travis.yml
##########
@@ -80,7 +80,7 @@ install:
script:
- ant -q clean
- - travis_wait 120 "./.travis/antTest.sh"
+ - "./.travis/antTest.sh"
Review comment:
This command will not exceed 60 mins? [https://app.travis-ci.com/github/apache/tomcat/jobs/529778525](https://app.travis-ci.com/github/apache/tomcat/jobs/529778525)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #445:
URL: https://github.com/apache/tomcat/pull/445#discussion_r690178459
##########
File path: .travis.yml
##########
@@ -90,3 +90,6 @@ after_failure:
notifications:
email:
- dev@tomcat.apache.org
+cache:
+ directories:
+ - $HOME/.m2
Review comment:
Where is it ?
Did you confuse it with `build.xml` (Ant) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #445: Improve Travis CI build Performance
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #445:
URL: https://github.com/apache/tomcat/pull/445#issuecomment-900037585
The use of `travis_wait` is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org