[GitHub] [ignite] Sega76 commented on a change in pull request #9142: IGNITE-14477: added ducktape rebalance persistent_test.

[GitBox <gi...@apache.org>]

Sega76 commented on a change in pull request #9142:
URL: https://github.com/apache/ignite/pull/9142#discussion_r655945493



##########
File path: modules/ducktests/tests/ignitetest/tests/rebalance/__init__.py
##########
@@ -16,17 +16,43 @@
 """
 This package contains rebalance tests.
 """
-
+import sys

Review comment:
       This is not a test, general functions for rebalancing tests. transferred this to the rebalance/util.py

##########
File path: modules/ducktests/tests/ignitetest/tests/rebalance/__init__.py
##########
@@ -16,17 +16,43 @@
 """
 This package contains rebalance tests.
 """
-
+import sys
+from enum import IntEnum
 from typing import NamedTuple
 
 # pylint: disable=W0622
 from ducktape.errors import TimeoutError
 
+from ignitetest.services.ignite import IgniteService
 from ignitetest.services.ignite_app import IgniteApplicationService
 
 
 # pylint: disable=too-many-arguments
-def preload_data(context, config, preloaders, backups, cache_count, entry_count, entry_size, timeout=3600):
+from ignitetest.services.utils.ignite_aware import IgniteAwareService
+from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration
+from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration
+from ignitetest.utils.enum import constructible
+from ignitetest.utils.version import IgniteVersion
+
+NUM_NODES = 4
+DEFAULT_DATA_REGION_SZ = 1024 * 1024 * 1024

Review comment:
       done

##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -287,17 +288,18 @@ def event_time(evt_message, node):
 
         return datetime.strptime(match.group(), "[%Y-%m-%d %H:%M:%S,%f]") if match else None
 
-    def get_event_time_on_node(self, node, log_pattern, from_the_beginning=True, timeout=15):
+    @staticmethod

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org