Re: [PR] [cdc-cli] When using miniCluster, don't check 'FLINK_HOME'. [flink-cdc]

["PatrickRen (via GitHub)" <gi...@apache.org>]

PatrickRen commented on code in PR #2813:
URL: https://github.com/apache/flink-cdc/pull/2813#discussion_r1549286234


##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontend.java:
##########
@@ -86,6 +87,18 @@ static CliExecutor createExecutor(CommandLine commandLine) throws Exception {
         // Global pipeline configuration
         Configuration globalPipelineConfig = getGlobalConfig(commandLine);
 
+        // Create pipeline composer
+        boolean useMiniCluster = commandLine.hasOption(CliFrontendOptions.USE_MINI_CLUSTER);

Review Comment:
   How could the MiniCluster run without specifying `FLINK_HOME`? We don't package `flink-dist` into our distribution, so I assume that the MiniCluster cannot even be started without specifying the place where Flink related classes are. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org