You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/31 11:58:36 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1099: rptun cmd update

xiaoxiang781216 commented on a change in pull request #1099:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1099#discussion_r839522414



##########
File path: nshlib/nsh_command.c
##########
@@ -466,7 +466,8 @@ static const struct cmdmap_s g_cmdmap[] =
 #endif
 
 #if defined(CONFIG_RPTUN) && !defined(CONFIG_NSH_DISABLE_RPTUN)
-  { "rptun",    cmd_rptun,    3, 3, "start|stop <dev-path>" },
+  { "rptun",    cmd_rptun,    2, 6,
+    "start|stop|reset|panic|dump|ping [dev-path] [value|times length ack]" },

Review comment:
       let's handle optional [dev-path] correctly




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org