You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/18 07:07:59 UTC
[GitHub] [hive] omalley opened a new pull request #1410: Move the Hive website to github pages.
omalley opened a new pull request #1410:
URL: https://github.com/apache/hive/pull/1410
This pull request adds a site to our main branch that contains the source code to the site.
We can ask Infra to automatically build and deploy github-pages from that branch & directory.
To look at the translated site, there is a docker file and a readme that will build the site locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] omalley closed pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
omalley closed pull request #1410:
URL: https://github.com/apache/hive/pull/1410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] massdosage commented on a change in pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
massdosage commented on a change in pull request #1410:
URL: https://github.com/apache/hive/pull/1410#discussion_r472075050
##########
File path: site/privacy_policy.md
##########
@@ -0,0 +1,30 @@
+---
+title: Privary Policy
Review comment:
```suggestion
title: Privacy Policy
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-682040232
> So I moved all of the references to the subversion. Hopefully, they'll let us keep that svn repository.
awesome :)
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] omalley commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
omalley commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-680317038
I couldn't make my idea of pushing to an empty branch work. I made such a branch https://github.com/omalley/hive/tree/javadoc-3.1 , but GitHub's presentation logic seems to block my attempts to reference it. Even, https://raw.githubusercontent.com/omalley/hive/javadoc-3.1/index.html serves it up a plain/text.
So I moved all of the references to the subversion. Hopefully, they'll let us keep that svn repository.
It would be good to move forward on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-680111530
> One of the advantages of including the site in docs on the main branch is that it will automatically get packaged as part of the releases, so I'd rather not give that up
I think when releases are made we should also produce a `javadoc` jar - which should contain the actual docs... however - I might have misunderstood your comment.
Let's consider for a moment that we would be putting the javadocs into the main branch: in that case I think every commit *must* also update the generated javadocs - to keep them up-to-date ; which would increase commit sizes, burden on contributors - and could also make commits harder to be reviewed...
> How about if we put the generated javadoc in a branch named "javadoc-3.1". We could point the site to reference that branch on github. Would that be acceptable?
If that's possible - then that would be a great solution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] omalley commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
omalley commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-676537470
Agreed that it is a lot of files, but if the project wants to continue to publish javadocs we need to host them somewhere. The current site keeps 6 versions in subversion. I cut that down to 1 in the conversion. I believe that Apache Infra wants to shut down the subversion that is currently hosting those javadocs.
I'm open to solutions, including stopping publishing Hive's javadocs. What would you suggest?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-676313383
this patch adds more than 5000 files, mostly because of javadoc stuff...
I think javadoc is an implicit content - and as such I think it shouldn't be "part" of the project repository
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-679885875
I just wanted to express that I don't think it's the best approach to expose javadocs like this...I really appreciate your efforts migrating the site - a few options I can think of:
* push the site into a different branch; like `gh-pages` - so we can pospone to solve this later...
* we can stop publishing javadoc on the site for now...
* or add some download&unpack to the site deploy script - not sure if this is possible..will need to check this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] omalley commented on pull request #1410: Move the Hive website to github pages.
Posted by GitBox <gi...@apache.org>.
omalley commented on pull request #1410:
URL: https://github.com/apache/hive/pull/1410#issuecomment-680102815
One of the advantages of including the site in docs on the main branch is that it will automatically get packaged as part of the releases, so I'd rather not give that up.
How about if we put the generated javadoc in a branch named "javadoc-3.1". We could point the site to reference that branch on github. Would that be acceptable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org