You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/01 21:09:06 UTC

[GitHub] [couchdb] jaydoane opened a new pull request #3813: Enable exunit in check target

jaydoane opened a new pull request #3813:
URL: https://github.com/apache/couchdb/pull/3813


   Currently, exunit tests are not run by the CI when `make check` runs.
   
   What happens when we enable it in Jenkins?
   
   Locally, it fails for me with:
   
   $ make exunit
   ==> config (compile)
   ==> b64url (compile)
   ==> ets_lru (compile)
   ==> khash (compile)
   ==> snappy (compile)
   ==> bear (compile)
   ==> meck (compile)
   ==> folsom (compile)
   ==> hyper (compile)
   ==> ibrowse (compile)
   ==> jiffy (compile)
   ==> mochiweb (compile)
   ==> recon (compile)
   WARN:  Missing plugins: [covertool]
   ==> proper (compile)
   ==> couch_epi (compile)
   ==> couch_log (compile)
   ==> chttpd (compile)
   ==> couch (compile)
   Compiling priv/couch_js/60/main.cpp
   In file included from priv/couch_js/60/main.cpp:27:
   In file included from /usr/local/include/mozjs-60/js/Wrapper.h:12:
   /usr/local/include/mozjs-60/js/Proxy.h:212:16: warning: offset of on non-standard-layout type 'js::BaseProxyHandler' [-Winvalid-offsetof]
           return offsetof(BaseProxyHandler, mFamily);
                  ^                          ~~~~~~~
   /Library/Developer/CommandLineTools/usr/lib/clang/11.0.0/include/stddef.h:120:24: note: expanded from macro 'offsetof'
   #define offsetof(t, d) __builtin_offsetof(t, d)
                          ^                     ~
   1 warning generated.
   Compiling priv/couch_js/60/util.cpp
   ==> couch_event (compile)
   ==> mem3 (compile)
   ==> couch_index (compile)
   ==> couch_mrview (compile)
   ==> couch_replicator (compile)
   ==> couch_plugins (compile)
   ==> couch_pse_tests (compile)
   ==> couch_stats (compile)
   ==> couch_peruser (compile)
   ==> couch_tests (compile)
   ==> couch_dist (compile)
   ==> custodian (compile)
   ==> ddoc_cache (compile)
   ==> dreyfus (compile)
   ==> fabric (compile)
   ==> global_changes (compile)
   ==> ioq (compile)
   ==> jwtf (compile)
   ==> ken (compile)
   ==> mango (compile)
   ==> rexi (compile)
   ==> setup (compile)
   ==> smoosh (compile)
   ==> weatherreport (compile)
   ==> couch_prometheus (compile)
   ==> rel (compile)
   ==> couchdb-3 (compile)
   * creating /Users/jay/.asdf/installs/elixir/1.10.4-otp-22/.mix/rebar
   * creating /Users/jay/.asdf/installs/elixir/1.10.4-otp-22/.mix/rebar3
   * creating /Users/jay/.asdf/installs/elixir/1.10.4-otp-22/.mix/archives/hex-0.21.3
   Resolving Hex dependencies...
   Dependency resolution completed:
   Unchanged:
     bunt 0.2.0
     certifi 2.5.1
     credo 1.5.4
     excoveralls 0.12.1
     file_system 0.2.10
     hackney 1.15.2
     httpotion 3.1.3 RETIRED!
       (deprecated) Not really maintained, please check out Tesla
     idna 6.0.0
     jason 1.2.2
     junit_formatter 3.0.0
     metrics 1.0.1
     mimerl 1.2.0
     parse_trans 3.3.0
     ssl_verify_fun 1.1.5
     unicode_util_compat 0.4.1
   WARN:  Missing plugins: [covertool]
   ==> couchdb-3 (setup_eunit)
   Writing tmp/etc/default_eunit.ini
   Writing tmp/etc/local_eunit.ini
   Writing tmp/etc/eunit.ini
   Writing tmp/etc/vm.args
   ===> Compiling parse_trans
   ===> Compiling b64url
   ===> "/Users/jay/proj/couchdb-3/src/b64url/ebin/b64url.app" is missing stdlib from applications list
   ===> Compiling mimerl
   ===> Compiling metrics
   ===> Compiling unicode_util_compat
   ===> Compiling idna
   ===> Compiling jiffy
   ===> Compiling jwtf
   src/jwtf_keystore.erl:15: Warning: behaviour config_listener undefined
   
   ===> Compiling certifi
   ===> Compiling hackney
   ==> httpotion
   Compiling 1 file (.ex)
   Generated httpotion app
   Checking 112 source files (this might take a while) ...
   
   info: some checks were skipped because they're not compatible with
   your version of Elixir (1.10.4).
   
   You can deactivate these checks by adding this to the `checks` list in your config:
   
       {Credo.Check.Refactor.MapInto, false},
       {Credo.Check.Warning.LazyLogging, false},
   
   Please report incorrect results: https://github.com/rrrene/credo/issues
   
   Analysis took 2.4 seconds (0.6s to load, 1.7s running 42 checks on 112 files)
   463 mods/funs, found no issues.
   
   Showing priority issues: ↑ ↗ →  (use `mix credo explain` to explain issues, `mix credo --help` for options).
   ===> Compiling b64url
   ===> "/Users/jay/proj/couchdb-3/src/b64url/ebin/b64url.app" is missing stdlib from applications list
   ===> Compiling jiffy
   ===> Compiling jwtf
   Compiling 14 files (.ex)
   warning: :compile_time_purge_level option for the :logger application is deprecated, use :compile_time_purge_matching instead
     test/elixir/lib/setup.ex:45: Couch.Test.Setup.setup_step/2
   
   warning: :compile_time_purge_level option for the :logger application is deprecated, use :compile_time_purge_matching instead
     test/elixir/lib/setup.ex:51: Couch.Test.Setup.setup_step/2
   
   Generated couchdbtest app
   
   SmooshSchedulingWindowTest
   Application asn1 was left running!
   
   14:03:12.535 [info]  Application asn1 exited: :stopped
   Application compiler was left running!
   
   14:03:12.537 [info]  Application compiler exited: :stopped
   Application public_key was left running!
   
   14:03:12.537 [info]  Application public_key exited: :stopped
   Application ssl was left running!
   
   14:03:12.539 [info]  Application ssl exited: :stopped
   Application ibrowse was left running!
   
   14:03:12.778 [info]  Application ibrowse exited: :stopped
   Application inets was left running!
   
   14:03:12.780 [info]  Application inets exited: :stopped
   make: *** [exunit] Error 1
   returned 2
   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb] jaydoane merged pull request #3813: Enable exunit in check target

Posted by GitBox <gi...@apache.org>.
jaydoane merged pull request #3813:
URL: https://github.com/apache/couchdb/pull/3813


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb] kocolosk commented on pull request #3813: Enable exunit in check target

Posted by GitBox <gi...@apache.org>.
kocolosk commented on pull request #3813:
URL: https://github.com/apache/couchdb/pull/3813#issuecomment-1018105787


   Heh, ironically I just _removed_ `exunit` from the CI checks in my refactored Jenkinsfile (which splits out the `check` targets to get better insight into execution times and progress) because I noticed it wasn't included in the 3.x Makefile. I'll re-added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org