You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Nick Westgate (JIRA)" <de...@tapestry.apache.org> on 2007/06/25 15:08:25 UTC
[jira] Created: (TAPESTRY-1599) Form "Prepare" event needs
disambiguation between render and submit-time invocations.
Form "Prepare" event needs disambiguation between render and submit-time invocations.
-------------------------------------------------------------------------------------
Key: TAPESTRY-1599
URL: https://issues.apache.org/jira/browse/TAPESTRY-1599
Project: Tapestry
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.0.5
Reporter: Nick Westgate
Priority: Minor
(I'm top posting over our previous correspondence below.)
My initial response would be that the optional context parameters signature is
very natural and that prepending a boolean would dilute the current API's clarity.
Do these events need to share the same name? It smacks of the rewind. ;-)
(Not to malign what was, at the time, a great idea.)
Cheers,
Nick.
Howard Lewis Ship wrote:
> I could change Form to pass along a boolean indicating whether it was
> for render or for submit. Please add an issue to JIRA.
>
> On 6/22/07, Nick Westgate <ni...@key-planning.co.jp> wrote:
>> Hi.
>>
>> Does anyone see a way to differentiate these prepare events?
>> I'm using an ugly hack because I can't find another way.
>>
>> boolean rendering;
>>
>> void setupRender()
>> {
>> rendering = true;
>> }
>>
>> public void onPrepareFromHistoryItemForm(int index)
>> {
>> if (rendering)
>> {
>> ...
>> }
>> }
>>
>> Cheers,
>> Nick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-1599) Form "Prepare" event needs
disambiguation between render and submit-time invocations.
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAPESTRY-1599:
----------------------------------------------
Assignee: Howard M. Lewis Ship
> Form "Prepare" event needs disambiguation between render and submit-time invocations.
> -------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1599
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1599
> Project: Tapestry
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Nick Westgate
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> (I'm top posting over our previous correspondence below.)
> My initial response would be that the optional context parameters signature is
> very natural and that prepending a boolean would dilute the current API's clarity.
> Do these events need to share the same name? It smacks of the rewind. ;-)
> (Not to malign what was, at the time, a great idea.)
> Cheers,
> Nick.
> Howard Lewis Ship wrote:
> > I could change Form to pass along a boolean indicating whether it was
> > for render or for submit. Please add an issue to JIRA.
> >
> > On 6/22/07, Nick Westgate <ni...@key-planning.co.jp> wrote:
> >> Hi.
> >>
> >> Does anyone see a way to differentiate these prepare events?
> >> I'm using an ugly hack because I can't find another way.
> >>
> >> boolean rendering;
> >>
> >> void setupRender()
> >> {
> >> rendering = true;
> >> }
> >>
> >> public void onPrepareFromHistoryItemForm(int index)
> >> {
> >> if (rendering)
> >> {
> >> ...
> >> }
> >> }
> >>
> >> Cheers,
> >> Nick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1599) Form "Prepare" event needs
disambiguation between render and submit-time invocations.
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560895#action_12560895 ]
Howard M. Lewis Ship commented on TAPESTRY-1599:
------------------------------------------------
OK, I think we'll fire a prepareForRender or a prepareForSubmit before firing the blanked prepare and continuing from there.
> Form "Prepare" event needs disambiguation between render and submit-time invocations.
> -------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1599
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1599
> Project: Tapestry
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Nick Westgate
> Priority: Minor
>
> (I'm top posting over our previous correspondence below.)
> My initial response would be that the optional context parameters signature is
> very natural and that prepending a boolean would dilute the current API's clarity.
> Do these events need to share the same name? It smacks of the rewind. ;-)
> (Not to malign what was, at the time, a great idea.)
> Cheers,
> Nick.
> Howard Lewis Ship wrote:
> > I could change Form to pass along a boolean indicating whether it was
> > for render or for submit. Please add an issue to JIRA.
> >
> > On 6/22/07, Nick Westgate <ni...@key-planning.co.jp> wrote:
> >> Hi.
> >>
> >> Does anyone see a way to differentiate these prepare events?
> >> I'm using an ugly hack because I can't find another way.
> >>
> >> boolean rendering;
> >>
> >> void setupRender()
> >> {
> >> rendering = true;
> >> }
> >>
> >> public void onPrepareFromHistoryItemForm(int index)
> >> {
> >> if (rendering)
> >> {
> >> ...
> >> }
> >> }
> >>
> >> Cheers,
> >> Nick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1599) Make it possible to differentiate
between preparing for a Form render vs. preparing for a Form submission
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1599.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.8
> Make it possible to differentiate between preparing for a Form render vs. preparing for a Form submission
> ---------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1599
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1599
> Project: Tapestry
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Nick Westgate
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.0.8
>
>
> (I'm top posting over our previous correspondence below.)
> My initial response would be that the optional context parameters signature is
> very natural and that prepending a boolean would dilute the current API's clarity.
> Do these events need to share the same name? It smacks of the rewind. ;-)
> (Not to malign what was, at the time, a great idea.)
> Cheers,
> Nick.
> Howard Lewis Ship wrote:
> > I could change Form to pass along a boolean indicating whether it was
> > for render or for submit. Please add an issue to JIRA.
> >
> > On 6/22/07, Nick Westgate <ni...@key-planning.co.jp> wrote:
> >> Hi.
> >>
> >> Does anyone see a way to differentiate these prepare events?
> >> I'm using an ugly hack because I can't find another way.
> >>
> >> boolean rendering;
> >>
> >> void setupRender()
> >> {
> >> rendering = true;
> >> }
> >>
> >> public void onPrepareFromHistoryItemForm(int index)
> >> {
> >> if (rendering)
> >> {
> >> ...
> >> }
> >> }
> >>
> >> Cheers,
> >> Nick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1599) Make it possible to differentiate
between preparing for a Form render vs. preparing for a Form submission
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-1599:
-------------------------------------------
Summary: Make it possible to differentiate between preparing for a Form render vs. preparing for a Form submission (was: Form "Prepare" event needs disambiguation between render and submit-time invocations.)
> Make it possible to differentiate between preparing for a Form render vs. preparing for a Form submission
> ---------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1599
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1599
> Project: Tapestry
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Nick Westgate
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.0.8
>
>
> (I'm top posting over our previous correspondence below.)
> My initial response would be that the optional context parameters signature is
> very natural and that prepending a boolean would dilute the current API's clarity.
> Do these events need to share the same name? It smacks of the rewind. ;-)
> (Not to malign what was, at the time, a great idea.)
> Cheers,
> Nick.
> Howard Lewis Ship wrote:
> > I could change Form to pass along a boolean indicating whether it was
> > for render or for submit. Please add an issue to JIRA.
> >
> > On 6/22/07, Nick Westgate <ni...@key-planning.co.jp> wrote:
> >> Hi.
> >>
> >> Does anyone see a way to differentiate these prepare events?
> >> I'm using an ugly hack because I can't find another way.
> >>
> >> boolean rendering;
> >>
> >> void setupRender()
> >> {
> >> rendering = true;
> >> }
> >>
> >> public void onPrepareFromHistoryItemForm(int index)
> >> {
> >> if (rendering)
> >> {
> >> ...
> >> }
> >> }
> >>
> >> Cheers,
> >> Nick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org