[GitHub] [spark] LuciferYang commented on a diff in pull request #42168: [SPARK-44556][SQL] Reuse `OrcTail` when enable vectorizedReader

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #42168:
URL: https://github.com/apache/spark/pull/42168#discussion_r1280137914


##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java:
##########
@@ -49,6 +50,7 @@ public class OrcColumnarBatchReader extends RecordReader<Void, ColumnarBatch> {
 
   // The capacity of vectorized batch.
   private int capacity;
+  private OrcTail orcTail;

Review Comment:
   really need this field? Maybe we can ref https://github.com/apache/spark/blob/52c1068190803d856959ba563642a3e440cc086c/sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java#L90-L105



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org