You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by ericliang <gi...@git.apache.org> on 2014/12/12 07:33:06 UTC
[GitHub] thrift pull request: erl lib: add recv_timeout configuration for c...
GitHub user ericliang opened a pull request:
https://github.com/apache/thrift/pull/317
erl lib: add recv_timeout configuration for client tcp connection
Tcp recv timeout is only used in server socket but in client, and thus client could block there to wait for the server response, which is not satisfied in time-critical situations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericliang/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #317
----
commit ecb230e1828dbdcf31ea151f119fb44c809fa5a6
Author: Eric Liang <er...@gmail.com>
Date: 2014-12-07T14:24:47Z
erl lib: add recv_timeout configuration for client tcp connection
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: erl lib: add recv_timeout configuration for c...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: erl lib: add recv_timeout configuration for c...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/317#issuecomment-93616620
Thanks for your patch @ericliang, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---