You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/10/29 20:23:21 UTC
Review Request 27343: Admin View: need better username validation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27343/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-8027
https://issues.apache.org/jira/browse/AMBARI-8027
Repository: ambari
Description
-------
1. Go to Manage Ambari
2. Try to create user
Result: user name field accept any special characters (!*?=.|/) etc.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js 3fc324a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js f34f4d5
ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js 5f96f90
ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0eff401
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js cf35d4f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 4ea048e
ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 76addd3
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java d4d61f7
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessorImpl.java bfb1e57
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java b184a59
ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java 9cfd8c6
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 116b6ec
ambari-web/app/router.js 25a142a
Diff: https://reviews.apache.org/r/27343/diff/
Testing
-------
Tested manually
Thanks,
Andrii Tkach
Re: Review Request 27343: Admin View: need better username validation
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27343/#review59037
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 29, 2014, 7:25 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27343/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 7:25 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Dmitro Lisnichenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8027
> https://issues.apache.org/jira/browse/AMBARI-8027
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Go to Manage Ambari
> 2. Try to create user
> Result: user name field accept any special characters (!*?=.|/) etc.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js 3fc324a
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js f34f4d5
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js 5f96f90
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0eff401
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js cf35d4f
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 4ea048e
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 76addd3
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java d4d61f7
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessorImpl.java bfb1e57
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java b184a59
> ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java 9cfd8c6
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 116b6ec
> ambari-web/app/router.js 25a142a
>
> Diff: https://reviews.apache.org/r/27343/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 27343: Admin View: need better username validation
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27343/
-----------------------------------------------------------
(Updated Окт. 29, 2014, 7:25 п.п.)
Review request for Ambari, Aleksandr Kovalenko, Dmitro Lisnichenko, and Srimanth Gunturi.
Bugs: AMBARI-8027
https://issues.apache.org/jira/browse/AMBARI-8027
Repository: ambari
Description
-------
1. Go to Manage Ambari
2. Try to create user
Result: user name field accept any special characters (!*?=.|/) etc.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js 3fc324a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js f34f4d5
ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js 5f96f90
ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0eff401
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js cf35d4f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 4ea048e
ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 76addd3
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java d4d61f7
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessorImpl.java bfb1e57
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java b184a59
ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java 9cfd8c6
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 116b6ec
ambari-web/app/router.js 25a142a
Diff: https://reviews.apache.org/r/27343/diff/
Testing
-------
Tested manually
Thanks,
Andrii Tkach
Re: Review Request 27343: Admin View: need better username validation
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27343/
-----------------------------------------------------------
(Updated Окт. 29, 2014, 7:24 п.п.)
Review request for Ambari, Aleksandr Kovalenko and Dmitro Lisnichenko.
Bugs: AMBARI-8027
https://issues.apache.org/jira/browse/AMBARI-8027
Repository: ambari
Description
-------
1. Go to Manage Ambari
2. Try to create user
Result: user name field accept any special characters (!*?=.|/) etc.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js 3fc324a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js f34f4d5
ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js 5f96f90
ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0eff401
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js cf35d4f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 4ea048e
ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 76addd3
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java d4d61f7
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessorImpl.java bfb1e57
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java b184a59
ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java 9cfd8c6
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 116b6ec
ambari-web/app/router.js 25a142a
Diff: https://reviews.apache.org/r/27343/diff/
Testing
-------
Tested manually
Thanks,
Andrii Tkach
Re: Review Request 27343: Admin View: need better username validation
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27343/#review59032
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 29, 2014, 7:23 після полудня, Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27343/
> -----------------------------------------------------------
>
> (Updated Жов. 29, 2014, 7:23 після полудня)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-8027
> https://issues.apache.org/jira/browse/AMBARI-8027
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Go to Manage Ambari
> 2. Try to create user
> Result: user name field accept any special characters (!*?=.|/) etc.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js 3fc324a
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js f34f4d5
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js 5f96f90
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0eff401
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js cf35d4f
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 4ea048e
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 76addd3
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java d4d61f7
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessorImpl.java bfb1e57
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java b184a59
> ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java 9cfd8c6
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 116b6ec
> ambari-web/app/router.js 25a142a
>
> Diff: https://reviews.apache.org/r/27343/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Andrii Tkach
>
>