You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/05 21:19:44 UTC
[PR] HDDS-10072. Update Container for named RwLock operations [ozone]
adoroszlai opened a new pull request, #5932:
URL: https://github.com/apache/ozone/pull/5932
## What changes were proposed in this pull request?
`Container` extends the `RwLock` interface from Hadoop, probably only for convenience. Hadoop 3.4 adds two new methods in `RwLock` (HDFS-16434) without default implementation. We either need to (1) implement these new methods, or (2) inline the methods used into `Container`. No code in Ozone makes use of the `RwLock` abstraction, so I think we can go with (2).
Q: should we keep methods implemented but not used in Ozone? (`readLockInterruptibly`, `writeLockInterruptibly`, `hasReadLock`)
https://issues.apache.org/jira/browse/HDDS-10072
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7426301421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10072. Update Container interface for named RwLock operations [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5932:
URL: https://github.com/apache/ozone/pull/5932#issuecomment-1883604398
Thanks @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10072. Update Container interface for named RwLock operations [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5932:
URL: https://github.com/apache/ozone/pull/5932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org