You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/10/23 04:39:39 UTC
Review Request: SQOOP-650: Add ability to name mapreduce job generated by
Sqoop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7706/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've added new extra parameter and made sure that it will be propagated to all places where Sqoop is creating mapreduce job.
This addresses bug SQOOP-650.
https://issues.apache.org/jira/browse/SQOOP-650
Diffs
-----
src/java/org/apache/sqoop/SqoopOptions.java 92c9996
src/java/org/apache/sqoop/mapreduce/ExportJobBase.java b9eaa83
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java efc2c37
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0c9cda6
src/java/org/apache/sqoop/tool/ExportTool.java 494887d
src/java/org/apache/sqoop/tool/ImportTool.java 415b315
Diff: https://reviews.apache.org/r/7706/diff/
Testing
-------
I've tested it on real hadoop cluster. I did not included any test cases as I'm not sure how to actually test this automatically.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-650: Add ability to name mapreduce job generated
by Sqoop
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7706/#review13188
-----------------------------------------------------------
Ship it!
Hi Jarcec,
I have a minor comment below. If you can upload a new patch to the jira, I will commit it after running tests.
Thanks!
src/java/org/apache/sqoop/tool/ExportTool.java
<https://reviews.apache.org/r/7706/#comment28360>
Can you please fix the indentation in these lines?
- Cheolsoo Park
On Oct. 23, 2012, 2:39 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7706/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2012, 2:39 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added new extra parameter and made sure that it will be propagated to all places where Sqoop is creating mapreduce job.
>
>
> This addresses bug SQOOP-650.
> https://issues.apache.org/jira/browse/SQOOP-650
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/SqoopOptions.java 92c9996
> src/java/org/apache/sqoop/mapreduce/ExportJobBase.java b9eaa83
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java efc2c37
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0c9cda6
> src/java/org/apache/sqoop/tool/ExportTool.java 494887d
> src/java/org/apache/sqoop/tool/ImportTool.java 415b315
>
> Diff: https://reviews.apache.org/r/7706/diff/
>
>
> Testing
> -------
>
> I've tested it on real hadoop cluster. I did not included any test cases as I'm not sure how to actually test this automatically.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-650: Add ability to name mapreduce job generated
by Sqoop
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7706/
-----------------------------------------------------------
(Updated Nov. 7, 2012, 12:13 a.m.)
Review request for Sqoop.
Changes
-------
Fixed indention issue.
Description
-------
I've added new extra parameter and made sure that it will be propagated to all places where Sqoop is creating mapreduce job.
This addresses bug SQOOP-650.
https://issues.apache.org/jira/browse/SQOOP-650
Diffs (updated)
-----
src/java/org/apache/sqoop/SqoopOptions.java 92c99962ae2276c1481657dfbeda4f14dfe7e8fc
src/java/org/apache/sqoop/mapreduce/ExportJobBase.java b9eaa834ecacdfcac300827dc7e187aec862661a
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java efc2c373366c86a2fcb28290979e18781cbc8995
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0c9cda610ccde6bd249f48fd438c88c94a239632
src/java/org/apache/sqoop/tool/ExportTool.java 494887d8c973048c4e3f6003e4f83e5baf8cff50
src/java/org/apache/sqoop/tool/ImportTool.java 415b315cf64bda65d110d60f33f3ee5cf2496292
Diff: https://reviews.apache.org/r/7706/diff/
Testing
-------
I've tested it on real hadoop cluster. I did not included any test cases as I'm not sure how to actually test this automatically.
Thanks,
Jarek Cecho