You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@twopensource.com> on 2014/10/03 18:51:19 UTC
Review Request 26320: Skip checkstyle on python file in 3rdparty.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Brian Wickman.
Bugs: AURORA-780
https://issues.apache.org/jira/browse/AURORA-780
Repository: aurora
Description
-------
Skip checkstyle on python file in 3rdparty.
Diffs
-----
3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
Diff: https://reviews.apache.org/r/26320/diff/
Testing
-------
Committed file w/ precommit hook in place.
Thanks,
Joshua Cohen
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Zameer Manji <zm...@twopensource.com>.
> On Oct. 16, 2014, 1:11 p.m., Kevin Sweeney wrote:
> > Is this still needed? I thought the checkstyle check was updated
I was under this impression as well.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review56991
-----------------------------------------------------------
On Oct. 3, 2014, 9:51 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 9:51 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Oct. 16, 2014, 8:11 p.m., Kevin Sweeney wrote:
> > Is this still needed? I thought the checkstyle check was updated
>
> Zameer Manji wrote:
> I was under this impression as well.
Ok, discarded.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review56991
-----------------------------------------------------------
On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review56991
-----------------------------------------------------------
Is this still needed? I thought the checkstyle check was updated
- Kevin Sweeney
On Oct. 3, 2014, 9:51 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 9:51 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Oct. 6, 2014, 4:33 p.m., Joshua Cohen wrote:
> > *ping* Kevin.
*ping* again. Once this ships the static assets changes from https://github.com/jcohen/incubator-aurora/commits/jcohen/static-assets (reviewed at https://reviews.apache.org/r/25835/) should be mergeable.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55511
-----------------------------------------------------------
On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55511
-----------------------------------------------------------
*ping* Kevin.
- Joshua Cohen
On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Oct. 8, 2014, 6:02 p.m., Kevin Sweeney wrote:
> > Apologies for the review delay.
> >
> > Is there a way we can tell checkstyle to avoid this file at all? I'd rather not make it a policy to patch each individual bower component we checkin.
Not without patching checkstyle alas.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55847
-----------------------------------------------------------
On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Oct. 8, 2014, 6:02 p.m., Kevin Sweeney wrote:
> > Apologies for the review delay.
> >
> > Is there a way we can tell checkstyle to avoid this file at all? I'd rather not make it a policy to patch each individual bower component we checkin.
>
> Joshua Cohen wrote:
> Not without patching checkstyle alas.
*ping* Kevin, any objections to shipping this?
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55847
-----------------------------------------------------------
On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55847
-----------------------------------------------------------
Apologies for the review delay.
Is there a way we can tell checkstyle to avoid this file at all? I'd rather not make it a policy to patch each individual bower component we checkin.
- Kevin Sweeney
On Oct. 3, 2014, 9:51 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 9:51 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55356
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26320/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Bugs: AURORA-780
> https://issues.apache.org/jira/browse/AURORA-780
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Skip checkstyle on python file in 3rdparty.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b
>
> Diff: https://reviews.apache.org/r/26320/diff/
>
>
> Testing
> -------
>
> Committed file w/ precommit hook in place.
>
>
> Thanks,
>
> Joshua Cohen
>
>