[jira] [Commented] (SOLR-14691) Metrics reporting should avoid creating objects

["Adrien Grand (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181418#comment-17181418 ] 

Adrien Grand commented on SOLR-14691:
-------------------------------------

[~ab] GC efficiency is important but I wonder if this really needs to be a blocker?

> Metrics reporting should avoid creating objects
> -----------------------------------------------
>
>                 Key: SOLR-14691
>                 URL: https://issues.apache.org/jira/browse/SOLR-14691
>             Project: Solr
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Andrzej Bialecki
>            Priority: Blocker
>             Fix For: 8.7
>
>
> {{MetricUtils}} unnecessarily creates a lot of short-lived objects (maps and lists). This affects GC, especially since metrics are frequently polled by clients. We should refactor it to use {{MapWriter}} as much as possible.
> Alternatively we could provide our wrappers or subclasses of Codahale metrics that implement {{MapWriter}}, then a lot of complexity in {{MetricUtils}} wouldn't be needed at all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org