You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/07 10:25:55 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #9514: Expire message by position.

eolivelli commented on a change in pull request #9514:
URL: https://github.com/apache/pulsar/pull/9514#discussion_r571593328



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentSubscription.java
##########
@@ -431,6 +431,11 @@ public void expireMessages(int messageTTLInSeconds) {
         // No-op
     }
 
+    @Override
+    public void expireMessages(Position position) {
+        // No-op

Review comment:
       Should be throw an error? Or at least log something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org