You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/10 03:57:43 UTC
Review Request 12392: Add missing semicolons
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12392/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
JSHint suggest semicolons after assignments. This does not affect functionality.
Diffs
-----
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
Diff: https://reviews.apache.org/r/12392/diff/
Testing
-------
Ran the app, rendered all templates.
Thanks,
Ross Allen
Re: Review Request 12392: Add missing semicolons
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 7:19 p.m., Ben Mahler wrote:
> > Ship It!
Would you mind comitting this for me?
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12392/#review22964
-----------------------------------------------------------
On July 10, 2013, 1:57 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12392/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:57 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> JSHint suggest semicolons after assignments. This does not affect functionality.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12392/diff/
>
>
> Testing
> -------
>
> Ran the app, rendered all templates.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12392: Add missing semicolons
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12392/#review22964
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 10, 2013, 1:57 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12392/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:57 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> JSHint suggest semicolons after assignments. This does not affect functionality.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12392/diff/
>
>
> Testing
> -------
>
> Ran the app, rendered all templates.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12392: Add missing semicolons
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12392/
-----------------------------------------------------------
(Updated July 12, 2013, 9:32 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
JSHint suggest semicolons after assignments. This does not affect functionality.
Diffs (updated)
-----
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
Diff: https://reviews.apache.org/r/12392/diff/
Testing
-------
Ran the app, rendered all templates.
Thanks,
Ross Allen
Re: Review Request 12392: Add missing semicolons
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12392/#review23018
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 10, 2013, 1:57 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12392/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:57 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> JSHint suggest semicolons after assignments. This does not affect functionality.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12392/diff/
>
>
> Testing
> -------
>
> Ran the app, rendered all templates.
>
>
> Thanks,
>
> Ross Allen
>
>