[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2801: Issue 2787: TestPerChannelBookieClient.testEpollChannelTcpUserTimeout fails

[GitBox <gi...@apache.org>]

dlg99 commented on a change in pull request #2801:
URL: https://github.com/apache/bookkeeper/pull/2801#discussion_r714379665



##########
File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestPerChannelBookieClient.java
##########
@@ -314,7 +314,7 @@ public void testEpollChannelTcpUserTimeout() throws Exception {
         EventLoopGroup eventLoopGroup = new EpollEventLoopGroup();
         OrderedExecutor executor = getOrderedSafeExecutor();
         ClientConfiguration conf = new ClientConfiguration();
-        int tcpUserTimeout = 1234;
+        int tcpUserTimeout = 1236; // this value may be rounded on some Linux implementations

Review comment:
       @eolivelli this smells like an endianness problem somewhere rather than a rounding problem. See https://github.com/jnr/jnr-unixsocket/pull/55 for example. Did it start at some BK version (dependencies updates etc) or it was the first run on these VMs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org