You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/07/01 00:23:31 UTC
Review Request 23180: Export a stat to track number of LOST gc_executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-562
https://issues.apache.org/jira/browse/AURORA-562
Repository: aurora
Description
-------
Track the number of LOST gc_executors
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
Diff: https://reviews.apache.org/r/23180/diff/
Testing
-------
$ ./gradlew test
Thanks,
Joe Smith
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Posted by Joe Smith <ya...@gmail.com>.
> On June 30, 2014, 3:29 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, line 113
> > <https://reviews.apache.org/r/23180/diff/1/?file=620659#file620659line113>
> >
> > Pull to previous line per preexisting style.
good eyes, thanks!
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/#review47019
-----------------------------------------------------------
On June 30, 2014, 4:12 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23180/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 4:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-562
> https://issues.apache.org/jira/browse/AURORA-562
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Track the number of LOST gc_executors
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
>
> Diff: https://reviews.apache.org/r/23180/diff/
>
>
> Testing
> -------
>
> $ ./gradlew test
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/#review47019
-----------------------------------------------------------
Ship it!
Once you post the style fix, i'll proceed with the commit. Thanks!
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java
<https://reviews.apache.org/r/23180/#comment82626>
Pull to previous line per preexisting style.
- Bill Farner
On June 30, 2014, 10:23 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23180/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 10:23 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-562
> https://issues.apache.org/jira/browse/AURORA-562
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Track the number of LOST gc_executors
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
>
> Diff: https://reviews.apache.org/r/23180/diff/
>
>
> Testing
> -------
>
> $ ./gradlew test
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/#review47323
-----------------------------------------------------------
This is now on master, thanks!
commit 2f62116
Author: Joe Smith <ya...@gmail.com>
Date: Thu Jul 3 13:48:00 2014 -0700
Export a stat to track number of LOST gc_executors
Bugs closed: AURORA-562
Reviewed at https://reviews.apache.org/r/23180/
- Bill Farner
On July 3, 2014, 7:30 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23180/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 7:30 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-562
> https://issues.apache.org/jira/browse/AURORA-562
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Track the number of LOST gc_executors
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java e1f69775e1fb86df1d686d3e2e0be7937b11cf8f
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
>
> Diff: https://reviews.apache.org/r/23180/diff/
>
>
> Testing
> -------
>
> $ ./gradlew test
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/
-----------------------------------------------------------
(Updated July 3, 2014, 12:30 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
$ ./gradlew build -Pq
<snip>
BUILD SUCCESSFUL
Total time: 3 mins 45.879 secs
Bugs: AURORA-562
https://issues.apache.org/jira/browse/AURORA-562
Repository: aurora
Description
-------
Track the number of LOST gc_executors
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java e1f69775e1fb86df1d686d3e2e0be7937b11cf8f
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
Diff: https://reviews.apache.org/r/23180/diff/
Testing
-------
$ ./gradlew test
Thanks,
Joe Smith
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/#review47121
-----------------------------------------------------------
Build failed with this patch. Please try running ./gradlew build -Pq, and fix.
:compileTestJava
/home/wfarner/code/aurora/src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java:215: warning: [static] static method should be qualified by type name, GcExecutorLauncher, instead of by an expression
TaskInfo task = gcExecutorLauncher.makeGcTask(HOST, OFFER.getSlaveId(), SETTINGS.getGcExecutorPath().get(), TASK_UUID, message);
^
error: warnings found and -Werror specified
1 error
1 warning
:compileTestJava FAILED
- Bill Farner
On June 30, 2014, 11:12 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23180/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 11:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-562
> https://issues.apache.org/jira/browse/AURORA-562
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Track the number of LOST gc_executors
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
>
> Diff: https://reviews.apache.org/r/23180/diff/
>
>
> Testing
> -------
>
> $ ./gradlew test
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/
-----------------------------------------------------------
(Updated June 30, 2014, 4:12 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
style fix
Bugs: AURORA-562
https://issues.apache.org/jira/browse/AURORA-562
Repository: aurora
Description
-------
Track the number of LOST gc_executors
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb
Diff: https://reviews.apache.org/r/23180/diff/
Testing
-------
$ ./gradlew test
Thanks,
Joe Smith