You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/03/19 16:46:10 UTC

[GitHub] [hive] amanraj2520 opened a new pull request, #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

amanraj2520 opened a new pull request, #4125:
URL: https://github.com/apache/hive/pull/4125

JIRA : https://issues.apache.org/jira/browse/HIVE-27151

The multi_in_clause.q fails because Hive is not able to parse
explain cbo
select * from very_simple_table_for_in_test where name IN('g','r') AND name IN('a','b')
If we want this to work, I am able to do it in my local. We have 2 options :
a. Either revert [HIVE-21685](https://issues.apache.org/jira/browse/HIVE-21685) since this scenario was not validated back then before adding this test.
b. This fix was present in https://issues.apache.org/jira/browse/HIVE-20718 but to cherry pick this we need to cherry pick https://issues.apache.org/jira/browse/HIVE-17040 since [HIVE-20718](https://issues.apache.org/jira/browse/HIVE-20718) has a lot of merge conflicts with [HIVE-17040](https://issues.apache.org/jira/browse/HIVE-17040). But after cherry picking these we have other failures to fix.

I am reverting this ticket for now.

This reverts commit fdaa342534f9ccfac9f1a7b53ef367003366fce8.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] vihangk1 merged pull request #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.

vihangk1 merged PR #4125:
URL: https://github.com/apache/hive/pull/4125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] vihangk1 commented on pull request #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.

vihangk1 commented on PR #4125:
URL: https://github.com/apache/hive/pull/4125#issuecomment-1477817372

   I submitted http://ci.hive.apache.org/job/hive-flaky-check/620/console to confirm if the new failure is a flaky test. Lets wait to see if it is indeed flaky and then we can merge this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] vihangk1 commented on pull request #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.

vihangk1 commented on PR #4125:
URL: https://github.com/apache/hive/pull/4125#issuecomment-1475627420

   Retriggered tests to confirm if the `org.apache.hadoop.hive.metastore.client.TestRuntimeStats` test failure is not related. Rest of the failures are known failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.

amanraj2520 commented on PR #4125:
URL: https://github.com/apache/hive/pull/4125#issuecomment-1475579300

   @vihangk1 Can you please review this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.

amanraj2520 commented on PR #4125:
URL: https://github.com/apache/hive/pull/4125#issuecomment-1479267453

   @vihangk1 Can you please merge this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] vihangk1 commented on pull request #4125: HIVE-27151 : Revert "HIVE-21685: Wrong simplification in query with multiple IN cl…

Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.

vihangk1 commented on PR #4125:
URL: https://github.com/apache/hive/pull/4125#issuecomment-1479653173

   That new test which fails doesn't seem to be flaky. Retriggered the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org