You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/12 00:01:11 UTC

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #6864: Qnn for first conv

anijain2305 commented on a change in pull request #6864:
URL: https://github.com/apache/incubator-tvm/pull/6864#discussion_r521715708



##########
File path: tests/python/relay/test_pass_auto_quantize.py
##########
@@ -148,7 +148,7 @@ def verify_partition(mod, params):
         assert (
             len(unpartitioned_mod.get_global_vars()) == 1
         ), "unpartitioned module should only have one function"
-    with relay.quantize.qconfig(**BASE_CFG, partition_conversions="fully_integral"):
+    with relay.quantize.qconfig(**BASE_CFG):

Review comment:
       Just read this comment. You already figure out. I am not sure about why. But, my guess would be that empirically the folks working on quantization might have seen big accuracy loss. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org