You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/27 21:40:29 UTC
[GitHub] [rocketmq-externals] imaffe opened a new pull request #539: [ISSUE
#538] Add required field in jdbc connector in code and documentation
imaffe opened a new pull request #539: [ISSUE #538] Add required field in jdbc connector in code and documentation
URL: https://github.com/apache/rocketmq-externals/pull/539
## What is the purpose of the change
Add 2 required field in jdbc sink connector configuration
## Brief changelog
1. add `source-rocketmq` and `source-cluster` to required config entries like :
```
public static final Set<String> REQUEST_CONFIG = new HashSet<String>() {
{
add(CONN_DB_IP);
add(CONN_DB_PORT);
add(CONN_DB_USERNAME);
add(CONN_DB_PASSWORD);
add(CONN_DB_MODE);
add("rocketmqTopic");
add(CONN_SOURCE_RMQ);
add(CONN_SOURCE_CLUSTER);
}
};
```
and in docs
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] duhenglucky merged pull request #539: [ISSUE
#538] WIP: Add required field in jdbc connector in code and documentation
Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #539: [ISSUE #538] WIP: Add required field in jdbc connector in code and documentation
URL: https://github.com/apache/rocketmq-externals/pull/539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] imaffe commented on issue #539: [ISSUE #538]
Add required field in jdbc connector in code and documentation
Posted by GitBox <gi...@apache.org>.
imaffe commented on issue #539: [ISSUE #538] Add required field in jdbc connector in code and documentation
URL: https://github.com/apache/rocketmq-externals/pull/539#issuecomment-605327419
Because I'm not sure what the sample `source-rocketmq` should look like (probably "127.0.0.1:9876 ")and haven't found answer in the code, I'll leave it as todo in the documents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services