You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/14 05:09:25 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36864: [SPARK-39463][CORE][TESTS] Use `UUID` for test database location in `JavaJdbcRDDSuite`

HyukjinKwon commented on code in PR #36864:
URL: https://github.com/apache/spark/pull/36864#discussion_r896378643


##########
core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java:
##########
@@ -32,6 +33,7 @@
 import org.junit.Test;
 
 public class JavaJdbcRDDSuite implements Serializable {
+  private String dbName = UUID.randomUUID().toString();

Review Comment:
   I remember it becomes flaky when the UUID starts with numbers (in Spark SQL), e.g.. `SQLTestUtils.withTempDatabase`. Should we better copy and paste that here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org