[GitHub] [airflow] uranusjr commented on a diff in pull request #25762: Use temporary directories for tests remote aws loggers

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #25762:
URL: https://github.com/apache/airflow/pull/25762#discussion_r948058995


##########
tests/providers/amazon/aws/log/test_cloudwatch_task_handler.py:
##########
@@ -55,10 +55,10 @@ def logmock():
 class TestCloudwatchTaskHandler:
     @conf_vars({('logging', 'remote_log_conn_id'): 'aws_default'})
     @pytest.fixture(autouse=True)
-    def setup(self, create_log_template):
+    def setup(self, create_log_template, tmpdir_factory):

Review Comment:
   ```suggestion
       def setup(self, create_log_template, tmp_path_factory):
   ```
   
   I believe `tmpdir` and `tmpdir_factory` usages are strongly discouraged now in favour of `tmp_path` and `tmp_path_factory` (which use the stdlib pathlib).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org