You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/02 12:17:45 UTC

[GitHub] [commons-collections] dota17 commented on a change in pull request #165: [COLLECTIONS-764] Refine javadoc and fix typos

dota17 commented on a change in pull request #165:
URL: https://github.com/apache/commons-collections/pull/165#discussion_r433830911



##########
File path: src/main/java/org/apache/commons/collections4/list/CursorableLinkedList.java
##########
@@ -279,7 +279,7 @@ protected void registerCursor(final Cursor<E> cursor) {
     }
 
     /**
-     * Deregisters a cursor from the list to be notified of changes.
+     * Deregister a cursor from the list to be notified of changes.

Review comment:
       garydgregory on 17 Apr Member
   If a method starts with "make...", it usually reads better to start the Javadoc with "Makes..." IMO, It's confusing to have the Javadoc be different, otherwise you could say that all method that start with "set..." also "forces" a value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org