You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/04/11 10:59:59 UTC

Review Request 58345: Remove duplicate condition from route

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58345/
-----------------------------------------------------------

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20732
    https://issues.apache.org/jira/browse/ambari-20732


Repository: ambari


Description
-------

{{adminServiceAutoStart.enter}}  contains duplicate {{!App.isAuthorized('CLUSTER.MANAGE_AUTO_START')}}.


Diffs
-----

  ambari-web/app/routes/main.js 0a2375e 
  ambari-web/test/controllers/main_test.js 9673092 
  ambari-web/test/init_test.js db72744 


Diff: https://reviews.apache.org/r/58345/diff/1/


Testing
-------

20663 passing (23s)
  128 pending


Thanks,

Oleg Nechiporenko


Re: Review Request 58345: Remove duplicate condition from route

Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58345/#review171553
-----------------------------------------------------------


Ship it!




Ship It!

- Denys Buzhor


On April 11, 2017, 10:59 a.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58345/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 10:59 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20732
>     https://issues.apache.org/jira/browse/ambari-20732
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {{adminServiceAutoStart.enter}}  contains duplicate {{!App.isAuthorized('CLUSTER.MANAGE_AUTO_START')}}.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/routes/main.js 0a2375e 
>   ambari-web/test/controllers/main_test.js 9673092 
>   ambari-web/test/init_test.js db72744 
> 
> 
> Diff: https://reviews.apache.org/r/58345/diff/1/
> 
> 
> Testing
> -------
> 
> 20663 passing (23s)
>   128 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>