You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/06/26 20:12:49 UTC

[jira] Created: (HBASE-2795) On review HBASE-2707 has problem in that we'll get stuck in the delay queue and never come out

On review HBASE-2707 has problem in that we'll get stuck in the delay queue and never come out
----------------------------------------------------------------------------------------------

                 Key: HBASE-2795
                 URL: https://issues.apache.org/jira/browse/HBASE-2795
             Project: HBase
          Issue Type: Bug
            Reporter: stack


I committed the hbase-2707 patch yesterday but on second thoughts, it has a flaw in that if nothing in the todo queue, we then poll the delayedtodo queue.  If we fall into the latter and it has not elements, then we'll never come out; there are no notifyalls going on to wake us up.  Patch coming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2795) On review HBASE-2707 has problem in that we'll get stuck in the delay queue and never come out

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-2795:
-------------------------

    Attachment: 2707-extratest.txt

Here is a test that proves my assumption that 2707 patch has a flaw is wrong.  I committed this test under the aegis of this issue. Now I'm going to resolve this invalid.

> On review HBASE-2707 has problem in that we'll get stuck in the delay queue and never come out
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-2795
>                 URL: https://issues.apache.org/jira/browse/HBASE-2795
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: 2707-extratest.txt
>
>
> I committed the hbase-2707 patch yesterday but on second thoughts, it has a flaw in that if nothing in the todo queue, we then poll the delayedtodo queue.  If we fall into the latter and it has not elements, then we'll never come out; there are no notifyalls going on to wake us up.  Patch coming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-2795) On review HBASE-2707 has problem in that we'll get stuck in the delay queue and never come out

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-2795.
--------------------------

    Resolution: Invalid

Invalid.  Not an actual problem.

> On review HBASE-2707 has problem in that we'll get stuck in the delay queue and never come out
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-2795
>                 URL: https://issues.apache.org/jira/browse/HBASE-2795
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: 2707-extratest.txt
>
>
> I committed the hbase-2707 patch yesterday but on second thoughts, it has a flaw in that if nothing in the todo queue, we then poll the delayedtodo queue.  If we fall into the latter and it has not elements, then we'll never come out; there are no notifyalls going on to wake us up.  Patch coming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.