You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Bo Wang (JIRA)" <ji...@apache.org> on 2015/06/08 04:48:00 UTC
[jira] [Updated] (KAFKA-2254) The shell script should be optimized
, even kafka-run-class.sh has a syntax error.
[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bo Wang updated KAFKA-2254:
---------------------------
Description:
kafka-run-class.sh 128 line has a syntax error(missing a space):
127 -loggc)
128 if [ -z "$KAFKA_GC_LOG_OPTS"] ; then
129 GC_LOG_ENABLED="true"
130 fi
And use the ShellCheck to check the shell scripts, the results shows some errors 、 warnings and notes：
https://github.com/koalaman/shellcheck/wiki/SC2068
https://github.com/koalaman/shellcheck/wiki/Sc2046
https://github.com/koalaman/shellcheck/wiki/Sc2086
was:
kafka-run-class.sh 128 line has a syntax error(missing a space):
127 -loggc)
128 if [ -z "$KAFKA_GC_LOG_OPTS"] ; then
129 GC_LOG_ENABLED="true"
130 fi
And use the ShellCheck to check the shell scripts, the results shows some errors and warnings and notes：
https://github.com/koalaman/shellcheck/wiki/SC2068
https://github.com/koalaman/shellcheck/wiki/Sc2046
https://github.com/koalaman/shellcheck/wiki/Sc2086
> The shell script should be optimized , even kafka-run-class.sh has a syntax error.
> ----------------------------------------------------------------------------------
>
> Key: KAFKA-2254
> URL: https://issues.apache.org/jira/browse/KAFKA-2254
> Project: Kafka
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.2.1
> Environment: linux
> Reporter: Bo Wang
> Priority: Critical
> Labels: client-script, kafka-run-class.sh, shell-script
> Fix For: 0.8.2.1
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> kafka-run-class.sh 128 line has a syntax error(missing a space):
> 127 -loggc)
> 128 if [ -z "$KAFKA_GC_LOG_OPTS"] ; then
> 129 GC_LOG_ENABLED="true"
> 130 fi
> And use the ShellCheck to check the shell scripts, the results shows some errors 、 warnings and notes：
> https://github.com/koalaman/shellcheck/wiki/SC2068
> https://github.com/koalaman/shellcheck/wiki/Sc2046
> https://github.com/koalaman/shellcheck/wiki/Sc2086
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)