You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/02 10:49:46 UTC

[GitHub] incubator-netbeans pull request #38: [NETBEANS-54] Module Review editor.lib2

GitHub user vieiro opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/38

    [NETBEANS-54] Module Review editor.lib2

    - No external libraries.
    - checked Rat report: modified license header in src/org/netbeans/api/editor/caret/package.html
    - skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-editor.lib2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit cb443c2efbbd41df528c4166f0b0a629d899cec5
Author: Antonio Vieiro <an...@vieiro.net>
Date:   2017-10-02T10:46:40Z

    [NETBEANS-54] Module Review editor.lib2
    
    - No external libraries.
    - checked Rat report: modified license header in src/org/netbeans/api/editor/caret/package.html
    - skimmed through the module, did not notice additional problems

----


---

[GitHub] incubator-netbeans issue #38: [NETBEANS-54] Module Review editor.lib2

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/38
  
    Merged with 2 positive reviews.


---

[GitHub] incubator-netbeans pull request #38: [NETBEANS-54] Module Review editor.lib2

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/38


---