You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2019/02/13 22:13:53 UTC
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12475
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
The test 'test_jvm_pause_monitor_logs_entries' stops and starts an
impalad, and confirms that that the JVM pause monitor detects the pause
by looking for a specific message in the log. In a test run the test
failed to find the correct message after sleeping for 1.2 seconds.
Because the test notes the last message that it sees in the log, we can
observe that the test would have found the correct message if it had
waited for just a few more milliseconds.
This change increases the time that the test waits to 2 seconds.
TESTING:
Ran end-to-end tests cleanly and checked that
test_jvm_pause_monitor_logs_entries ran OK.
Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
---
M tests/custom_cluster/test_pause_monitor.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/12475/1
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12475 )
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 22:56:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12475 )
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 02:57:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12475 )
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
The test 'test_jvm_pause_monitor_logs_entries' stops and starts an
impalad, and confirms that that the JVM pause monitor detects the pause
by looking for a specific message in the log. In a test run the test
failed to find the correct message after sleeping for 1.2 seconds.
Because the test notes the last message that it sees in the log, we can
observe that the test would have found the correct message if it had
waited for just a few more milliseconds.
This change increases the time that the test waits to 2 seconds.
TESTING:
Ran end-to-end tests cleanly and checked that
test_jvm_pause_monitor_logs_entries ran OK.
Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Reviewed-on: http://gerrit.cloudera.org:8080/12475
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_pause_monitor.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12475 )
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3772/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 22:56:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12475 )
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 22:56:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12475 )
Change subject: IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/2112/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/12475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Gerrit-Change-Number: 12475
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 22:48:21 +0000
Gerrit-HasComments: No