[GitHub] [incubator-druid] clintropolis commented on issue #8363: Zookeeper version is updated.

[GitBox <gi...@apache.org>]

clintropolis commented on issue #8363: Zookeeper version is updated.
URL: https://github.com/apache/incubator-druid/pull/8363#issuecomment-523695485
 
 
   This is a somewhat duplicate of #8177, but maybe still worth going ahead and doing since the other is tied up in the curator issue.
   
   After #7998 and #8306 (which was just merged and the cause of your conflicts), `LICENSE.BINARY` and `NOTICE.BINARY` are both autogenerated from the contents of `licenses.yaml` at the root of the project. #8367 will add instructions to the PR template indicating that this should be done if dependency versions are bumped, but it is not merged yet.
   
   Could you please fix conflicts update the zookeeper entry 'version' and 'notice' text in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml#L1453)? 
   
   For the notice, it looks like changing to:
   
   ```
   Apache ZooKeeper
   Copyright 2009-2019 The Apache Software Foundation
   ```
   
   [should be sufficient](https://github.com/apache/zookeeper/blob/4c25d480e66aadd371de8bd2fd8da255ac140bcf/NOTICE.txt).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org